Use standard return code and content-type#20
Merged
vkhoroz merged 1 commit intofoundriesio:mainfrom Feb 13, 2026
Merged
Conversation
vkhoroz
reviewed
Feb 12, 2026
Member
vkhoroz
left a comment
vkhoroz
left a comment
There was a problem hiding this comment.
Thanks for the commit @orangepizza .
I think we should be functionally fine; only need to cleanup the comments and tests.
orangepizza
force-pushed
the
standard-types
branch
3 times, most recently
from
a92c7b9 to
d38a498
Compare
vkhoroz
reviewed
Feb 12, 2026
RFC7030 4.2.3 requires return code 200 and content type with smime-type certs-only parameter. Old versions of fioconfig-clients have wrong expectations, so added check to mimic old behavior for old client Signed-off-by: Seo Suchan <tjtncks@gmail.com>
orangepizza
force-pushed
the
standard-types
branch
from
d38a498 to
3058a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC7030 4.2.3 requires return code 200 and content type with smime-type certs-only parameter. Old versions of fioconfig-clients have wrong expectations, so added check to mimic old behavior.
Signed-off-by: Seo Suchan tjtncks@gmail.com
fixes #19