Skip to content

Receive Unified Plan tracks on Android #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCryptoDonkey merged 1 commit into from
Sep 20, 2026
Merged

Receive Unified Plan tracks on Android #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/androidTest/kotlin/dev/forgesworn/kithmoot/media/BrowserCallInteropTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ class BrowserCallInteropTest {
if (ready) scope.launch { runCatching { link.onNegotiationNeeded() }.onFailure { failure.set(it.toString()) } }
}
override fun onAddTrack(receiver: RtpReceiver?, streams: Array<out MediaStream>?) { receiver?.track()?.let { received[it.id()] = it } }
override fun onTrack(transceiver: RtpTransceiver?) = Unit
override fun onTrack(transceiver: RtpTransceiver?) {
transceiver?.receiver?.track()?.let { received[it.id()] = it }
}
}
val pc = requireNotNull(factory.createPeerConnection(configuration, observer))
val videoSource = factory.createVideoSource(false)
Expand Down
11 changes: 8 additions & 3 deletions app/src/main/kotlin/dev/forgesworn/kithmoot/media/WebRtcEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,14 @@ class WebRtcEngine(
refreshRemoteTracks()
}

// Unified Plan fires this once a transceiver's receiver has a
// track to hand over.
override fun onTrack(transceiver: RtpTransceiver?) = refreshRemoteTracks()
// Unified Plan delivers the receiver here. Do not rely on the
// older onAddTrack callback also firing: refreshRemoteTracks reads
// the separately owned objects in `received`, because a fresh
// getTransceivers() snapshot disposes its previous Java wrappers.
override fun onTrack(transceiver: RtpTransceiver?) {
transceiver?.receiver?.track()?.let { received[it.id()] = it }
refreshRemoteTracks()
}
}

fun attach(connection: PeerConnection) {
Expand Down
Loading