Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The review has no active issues for the IMAP-loading and FrankenPHP-exclusion changes.
No open issues 🎉
What changed in this PR
Adds automatic loading of bundled IMAP extensions for regular PHP, supporting #107, while excluding IMAP from FrankenPHP because it is not thread-safe.
Changes:
- Adds IMAP to extension loading and introduces a skip list used by FrankenPHP.
- Adds a test covering normal loading and thread-unsafe extension exclusion.
- Documents IMAP availability and its FrankenPHP and Kerberos limitations.
| File | Description |
|---|---|
internal/php/php.go |
Adds IMAP loading and optional extension exclusions. |
internal/php/php_test.go |
Tests IMAP loading and exclusion while preserving other extensions. |
internal/frankenphp/frankenphp.go |
Excludes thread-unsafe extensions from generated FrankenPHP configuration. |
docs/php.md |
Lists IMAP and documents its limitations. |
Review effort: Balanced
Member
|
Please see my reply in #107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107
What and why
Loads the imap extension that flock-php/binaries#48 adds to the PHP builds.
imapis added to the extensions Flock loads fromext/when present. On Windows 8.1–8.3 the official build already shipsphp_imap.dll, so it loads there right away.ext/, sophp.ThreadUnsafeExtensionskeeps it out of FrankenPHP's ini.docs/php.mdlists imap and the FrankenPHP and Kerberos limits.How I tested it
TestExtensionsIniSkipsThreadUnsafeForFrankenPHP.go test ./internal/php ./internal/frankenphppasses on Linux and on Windows;go run ./tools/docslintpasses.