Repository navigation
Conversation
This was referenced Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flock-php/flock#107
What and why
imap left PHP's core in 8.4 and Flock's PHP doesn't have it, so apps requiring
ext-imapcan't run on Flock.imapis added toshared_extensions, so every minor (8.1–8.5) shipsext/imap.so. 8.1–8.3 build the extension in php-src; 8.4+ build PECL imap 1.0.3, pinned inbuild.shlike opentelemetry. Linked against static-php-cli's c-client with OpenSSL, no Kerberos.ext/imap/tests, so static-php-cli treats the extension as extracted and skips the PECL source.build.shextracts php-src first and removes the leftover when it has noconfig.m4.frankenphp.skip_extensionstakes it out of the shared list in both jobs of the macOS and Linux workflows, so build, smoke test andflock-package.jsonagree.php_imap.dllup to 8.3. For 8.4 and 8.5 the packs add the PHP team's PECL DLL from downloads.php.net. Those have no published checksum, sophp.windows.extensions.imappins the SHA-256 per minor.buildraised for macOS, Linux and the Windows packs to rebuild the published versions.Flock loads the extension with flock-php/flock#109.
How I tested it
CI on my fork, nothing published: runs
php8.1.34, 8.2.35, 8.3.36, 8.4.27, 8.5.12 on macos-arm64, linux-x64 and linux-arm64: build, portability check and smoke test withREQUIRE_SHARED=1, then the fresh runner / no-Homebrew job.frankenphp8.4.27 on macos-arm64 and linux-x64: built without imap, smoke test passes.php-exts8.3, 8.4, 8.5: 8.4 and 8.5 loadimap 1.0.3.Locally, the official imap test suite (php-src
ext/imap/testsfor 8.1–8.3, PECL 1.0.3's for 8.4+) against Dovecot 2.3 with the suite's own config:Notes:
bug63126is skipped everywhere: it needs a GSSAPI-capable client and server, and none of these builds has Kerberos (upstream skips it on CI too).imap_fetchbody_basicfails in the suite itself: it usescase 'FT_UID';, deprecated in 8.5. With:it passes. Not fixed upstream yet.A Laravel app's imap import tests that failed with
Undefined constant "OP_SILENT"pass on the 8.4 and 8.5 macOS builds.