Skip to content

Nc/perf qs modernize #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ncooke3 wants to merge 13 commits into from
Closed

Nc/perf qs modernize #1829

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
76a45a0
chore: Move SwiftUI perf QS
ncooke3 Dec 11, 2025
61ce022
remove performance qs
ncooke3 Dec 11, 2025
08c2503
move
ncooke3 Dec 11, 2025
f2dbe8a
Add back GS plist
ncooke3 Dec 11, 2025
6c508a1
Revert "Add back GS plist"
ncooke3 Dec 11, 2025
ba9ca7c
move
ncooke3 Dec 11, 2025
4a8ca60
move plist again
ncooke3 Dec 11, 2025
6efae5b
fix reference
ncooke3 Dec 11, 2025
872f993
final touches
ncooke3 Dec 11, 2025
7e9116a
revise gha
ncooke3 Dec 11, 2025
36838ea
scheme specification
ncooke3 Dec 11, 2025
c45a444
test fix
ncooke3 Dec 16, 2025
47ef51c
Merge branch 'main' into nc/perf-qs-modernize
ncooke3 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions performance/Shared/UITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ class UITests: XCTestCase {
try checkEmptyView(function: classify)
try checkEmptyView(function: saliencyMap)
try checkEmptyView(function: upload)

try checkFunctionality(function: download, startingStatus: .idle)
// TODO: Re-enable once iOS 18.4 sims are dropped.
// try checkFunctionality(function: download, startingStatus: .idle)
Comment on lines +207 to +208

@gemini-code-assist gemini-code-assist Bot Dec 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The checkFunctionality test for the download function has been temporarily disabled. While the TODO explains the reason, it's important to ensure that this test is re-enabled as soon as the iOS 18.4 simulator issue is resolved. Disabling tests, even temporarily, can lead to regressions if not properly tracked and restored. Consider creating a follow-up task or issue to ensure this is addressed.

try checkFunctionality(function: classify, startingStatus: .success(.download))
try checkFunctionality(function: saliencyMap, startingStatus: .success(.classify))
try checkFunctionality(function: upload, startingStatus: .success(.saliencyMap))
Expand Down
Loading