Nc/perf qs modernize

[ncooke3]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a temporary modification to the performance UI tests by disabling a specific download functionality check. This adjustment is made to address potential compatibility issues, likely with a particular iOS simulator version, and includes a clear instruction to reinstate the test once the problematic simulator version is deprecated.

Highlights

• Test Temporarily Disabled: The download functionality test within UITests.swift has been temporarily commented out.
• Future Re-enablement: A TODO comment has been added, indicating that the download test should be re-enabled once iOS 18.4 simulators are no longer supported.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request temporarily disables a test case for the download functionality in UITests.swift with a TODO comment. This change should be tracked to ensure the test is re-enabled once the specified conditions are met, to maintain full test coverage.

[gemini-code-assist]

The checkFunctionality test for the download function has been temporarily disabled. While the TODO explains the reason, it's important to ensure that this test is re-enabled as soon as the iOS 18.4 simulator issue is resolved. Disabling tests, even temporarily, can lead to regressions if not properly tracked and restored. Consider creating a follow-up task or issue to ensure this is addressed.