Check if apphosting deployment exists. If not, omit apphosting config

src/firebase_studio/migrate.spec.ts

@@ -23,12 +23,12 @@
 
   describe("extractMetadata", () => {
     it("should use overrideProjectId if provided", async () => {
       sandbox.stub(fs, "readFile").callsFake(async (p: any) => {
         const pStr = p.toString();
         if (pStr.endsWith("metadata.json")) {
           return JSON.stringify({ projectId: "original-project" });
         }
         if (pStr.endsWith("blueprint.md")) {
           return "# **App Name**: Test App";
         }
         return "";
@@ -39,8 +39,8 @@
     });
 
     it("should fallback to metadata.json if no override is provided", async () => {
       sandbox.stub(fs, "readFile").callsFake(async (p: any) => {
         const pStr = p.toString();
         if (pStr.endsWith("metadata.json")) {
           return JSON.stringify({ projectId: "original-project" });
         }
@@ -201,10 +201,14 @@
       sandbox.restore();
     });
 
-    it("should call apphostingSecretsSetAction if .env exists and has a non-blank GEMINI_API_KEY", async () => {
+    it("should call apphostingSecretsSetAction if .env exists, has a non-blank GEMINI_API_KEY, and backends exist", async () => {
       const secretsStub = sandbox.stub(secrets, "apphostingSecretsSetAction").resolves();
       sandbox.stub(fs, "access").resolves();
       sandbox.stub(fs, "readFile").resolves("GEMINI_API_KEY=test-key");
+      sandbox.stub(apphosting, "listBackends").resolves({
+        backends: [{ name: "backend" }] as any[],
+        unreachable: [],
+      });
 
       await uploadSecrets(testRoot, "test-project");
 
@@ -220,10 +224,28 @@
       ).to.be.true;
     });
 
+    it("should not call apphostingSecretsSetAction if no backends exist", async () => {
+      const secretsStub = sandbox.stub(secrets, "apphostingSecretsSetAction").resolves();
+      sandbox.stub(fs, "access").resolves();
+      sandbox.stub(fs, "readFile").resolves("GEMINI_API_KEY=test-key");
+      sandbox.stub(apphosting, "listBackends").resolves({
+        backends: [],
+        unreachable: [],
+      });
+
+      await uploadSecrets(testRoot, "test-project");
+
+      expect(secretsStub.called).to.be.false;
+    });
+
     it("should not call apphostingSecretsSetAction if GEMINI_API_KEY is blank in .env", async () => {
       const secretsStub = sandbox.stub(secrets, "apphostingSecretsSetAction").resolves();
       sandbox.stub(fs, "access").resolves();
       sandbox.stub(fs, "readFile").resolves("GEMINI_API_KEY= ");
+      sandbox.stub(apphosting, "listBackends").resolves({
+        backends: [{ name: "backend" }] as any[],
+        unreachable: [],
+      });
 
       await uploadSecrets(testRoot, "test-project");
 

src/firebase_studio/migrate.ts

@@ -290,50 +290,69 @@ async function createFirebaseConfigs(
 
   // firebase.json (App Hosting)
   const firebaseJsonPath = path.join(rootPath, "firebase.json");
+  let firebaseJson: any;
   try {
-    await fs.access(firebaseJsonPath);
-    logger.info("ℹ️ firebase.json already exists, skipping creation.");
+    const content = await fs.readFile(firebaseJsonPath, "utf8");
+    firebaseJson = JSON.parse(content);
   } catch {
-    let backendId = "studio"; // Default
-    try {
-      logger.info(`⏳ Fetching App Hosting backends for project ${projectId}...`);
-      const backendsData = await apphosting.listBackends(projectId, "-");
-      const backends = backendsData.backends || [];
-
-      if (backends.length > 0) {
-        const studioBackend = backends.find(
-          (b) => b.name.endsWith("/studio") || b.name.toLowerCase().includes("studio"),
-        );
-        if (studioBackend) {
-          backendId = studioBackend.name.split("/").pop()!;
-        } else {
-          backendId = backends[0].name.split("/").pop()!;
-        }
-        logger.info(`✅ Selected App Hosting backend: ${backendId}`);
+    // Does not exist or not JSON
+  }
+
+  if (firebaseJson?.apphosting) {
+    logger.info("ℹ️ firebase.json already contains apphosting configuration, skipping.");
+    return;
+  }
+
+  let backendId: string | undefined;
+  try {
+    logger.info(`⏳ Fetching App Hosting backends for project ${projectId}...`);
+    const backendsData = await apphosting.listBackends(projectId, "-");
+    const backends = backendsData.backends || [];
+
+    if (backends.length > 0) {
+      const studioBackend = backends.find(
+        (b) => b.name.endsWith("/studio") || b.name.toLowerCase().includes("studio"),
+      );
+      if (studioBackend) {
+        backendId = studioBackend.name.split("/").pop()!;
       } else {
-        utils.logWarning('No App Hosting backends found, using default "studio"');
+        backendId = backends[0].name.split("/").pop()!;
       }
-    } catch (err: unknown) {
-      utils.logWarning(
-        `Could not fetch backends from Firebase CLI, using default "studio". ${err}`,
-      );
+      logger.info(`✅ Selected App Hosting backend: ${backendId}`);
     }
+  } catch (err: unknown) {
+    logger.debug(`Could not fetch backends from Firebase CLI: ${err}`);
+  }
 
-    const firebaseJson = {
-      apphosting: {
-        backendId: backendId,
-        ignore: [
-          "node_modules",
-          ".git",
-          ".agent",
-          ".idx",
-          "firebase-debug.log",
-          "firebase-debug.*.log",
-          "functions",
-        ],
-      },
-    };
-    await fs.writeFile(firebaseJsonPath, JSON.stringify(firebaseJson, null, 2));
+  if (!backendId) {
+    if (firebaseJson) {
+      logger.info("ℹ️ No App Hosting backends found, skipping update to existing firebase.json.");
+    } else {
+      logger.info("ℹ️ No App Hosting backends found, skipping creation of firebase.json.");
+    }
+    return;
+  }
+
+  const updatedFirebaseJson = {
+    ...firebaseJson,
+    apphosting: {
+      backendId: backendId,
+      ignore: [
+        "node_modules",
+        ".git",
+        ".agent",
+        ".idx",
+        "firebase-debug.log",
+        "firebase-debug.*.log",
+        "functions",
+      ],
+    },
+  };
+
+  await fs.writeFile(firebaseJsonPath, JSON.stringify(updatedFirebaseJson, null, 2));
+  if (firebaseJson) {
+    logger.info(`✅ Updated firebase.json with backendId: ${backendId}`);
+  } else {
     logger.info(`✅ Created firebase.json with backendId: ${backendId}`);
   }
 }
@@ -454,6 +473,19 @@ export async function uploadSecrets(
     return;
   }
 
+  try {
+    const backendsData = await apphosting.listBackends(projectId, "-");
+    if (!backendsData.backends || backendsData.backends.length === 0) {
+      logger.debug(
+        `No App Hosting backends found for project ${projectId}. Skipping secret upload.`,
+      );
+      return;
+    }
+  } catch (err: unknown) {
+    utils.logWarning(`Could not fetch App Hosting backends for project ${projectId}: ${err}`);
+    return;
+  }
+
   try {
     const envContent = await fs.readFile(envPath, "utf8");
     const parsedEnv = env.parse(envContent);