Check if apphosting deployment exists. If not, omit apphosting config

[christhompsongoogle]

Check if apphosting deployment exists. If not, omit apphosting configs.

TODO: what if firebase.json exists AND apphosting exists?

Description

Scenarios Tested

Sample Commands

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Studio migration process by introducing conditional logic for App Hosting configurations and secret uploads. It ensures that App Hosting-related actions, such as updating firebase.json or uploading secrets, only occur if App Hosting backends are actually deployed for the project, preventing unnecessary operations and improving the overall robustness and efficiency of the migration flow.

Highlights

• Conditional App Hosting Configuration: The createFirebaseConfigs function now intelligently checks for existing apphosting configurations in firebase.json and the presence of App Hosting backends before attempting to create or update the apphosting section.
• Conditional Secret Uploads: The uploadSecrets function now includes a pre-check to verify the existence of App Hosting backends, preventing secret upload attempts if no backends are found.
• Enhanced Test Coverage: New and updated test cases in migrate.spec.ts validate the conditional logic for App Hosting secret actions, ensuring they are only triggered when backends are present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/firebase_studio/migrate.spec.ts
  • Modified a test description to clarify the conditions for calling apphostingSecretsSetAction.
  • Added a new test case to verify that apphostingSecretsSetAction is not invoked when no App Hosting backends exist.
  • Updated an existing test to include the condition of App Hosting backends existing.
• src/firebase_studio/migrate.ts
  • Refactored the createFirebaseConfigs function to first read firebase.json if it exists, then check for an existing apphosting configuration, and finally, only proceed with App Hosting configuration if backends are found.
  • Modified the uploadSecrets function to include a check for the presence of App Hosting backends before attempting to read .env files and upload secrets.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a check to verify the existence of App Hosting backends before attempting to upload secrets. This is a good improvement that prevents unnecessary operations and potential errors when no backends are configured. The implementation is clean, follows repository best practices by adding an early exit, and includes appropriate test coverage for the new logic. I've added one minor suggestion to simplify a condition.

I am having trouble creating individual review comments. Click here to see my feedback.

src/firebase_studio/migrate.ts (459)

The listBackends function is guaranteed to return an object where backends is an array (even if empty). Therefore, the check for !backendsData.backends is redundant and can be removed for simplicity.

    if (backendsData.backends.length === 0) {

[joehan]

This call is duplicated now between here and createFirebaseConfig. Can we dedupe?