Skip to content

ci: re-enable proguard-tests:build in the CI unit path - #2526

Merged
demolaf merged 1 commit into
pre-GAfrom
ci/re-enable-proguard-tests
Sep 22, 2026
Merged

demolaf merged 1 commit into
pre-GAfrom
ci/re-enable-proguard-tests

Conversation

@demolaf

@demolaf demolaf commented Sep 22, 2026

Copy link
Copy Markdown
Member

scripts/build.sh has had proguard-tests:build commented out since January 2025, so nothing in 10.x has ever been checked against the consumer ProGuard rules the libraries ship. This re-enables it for GA. It passes as-is: no rule or module changes were needed.

Changes

  • Uncomment ./gradlew $GRADLE_ARGS proguard-tests:build in scripts/build.sh and drop the TODO(thatfiredev).
  • Update CONTRIBUTING.md and four okf-bundle/ docs so the documented step list, the known-trap entry and the module table match the script again.

Why this is the only R8 coverage

Every library sets isMinifyEnabled = false and only declares consumerProguardFiles, so :proguard-tests is the one place R8 applies them. Verified sensitive: removing -dontwarn com.facebook.** from auth-proguard.pro fails minifyReleaseWithR8.

Cost

build depends on check, so the unit path now also runs :proguard-tests:lintRelease plus lint analysis for its library dependencies, duplicating work lint.yml already does. A fully uncached run of the step measured under a minute. Worth knowing: a lint finding there aborts build.sh before checkstyle and the unit tests.


Maintainer note: Fixes internal CPRN-491

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the R8/ProGuard packaging gate (proguard-tests:build) in the CI build script (scripts/build.sh) and updates the associated documentation. The reviewer suggests optimizing this step by running :proguard-tests:assembleRelease instead of the full build task, which avoids executing redundant Android Lint checks and saves CI build time. The reviewer also provides corresponding documentation updates to align with this optimization.

Comment thread scripts/build.sh
Comment thread CONTRIBUTING.md
Comment thread okf-bundle/ci-workflows/android.md Outdated
Comment thread okf-bundle/ci-workflows/android.md Outdated
Comment thread okf-bundle/testing/agent-command-policy.md
Comment thread okf-bundle/testing/validation-checklist.md Outdated
@demolaf
demolaf force-pushed the ci/re-enable-proguard-tests branch from 12da71f to ba266b5 Compare September 22, 2026 09:47
@demolaf
demolaf force-pushed the ci/re-enable-proguard-tests branch from ba266b5 to e783449 Compare September 22, 2026 09:51
@demolaf
demolaf marked this pull request as ready for review September 22, 2026 09:51
@demolaf
demolaf merged commit 2652d37 into pre-GA Sep 22, 2026
10 checks passed
@demolaf
demolaf deleted the ci/re-enable-proguard-tests branch September 22, 2026 14:54
@github-project-automation github-project-automation Bot moved this from Backlog to Done in studio-2394994192-60a69 Sep 22, 2026
@demolaf demolaf mentioned this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants