ci: re-enable proguard-tests:build in the CI unit path - #2526
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the R8/ProGuard packaging gate (proguard-tests:build) in the CI build script (scripts/build.sh) and updates the associated documentation. The reviewer suggests optimizing this step by running :proguard-tests:assembleRelease instead of the full build task, which avoids executing redundant Android Lint checks and saves CI build time. The reviewer also provides corresponding documentation updates to align with this optimization.
demolaf
force-pushed
the
ci/re-enable-proguard-tests
branch
from
September 22, 2026 09:47
12da71f to
ba266b5
Compare
demolaf
force-pushed
the
ci/re-enable-proguard-tests
branch
from
September 22, 2026 09:51
ba266b5 to
e783449
Compare
demolaf
marked this pull request as ready for review
September 22, 2026 09:51
russellwheatley
approved these changes
Sep 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/build.shhas hadproguard-tests:buildcommented out since January 2025, so nothing in 10.x has ever been checked against the consumer ProGuard rules the libraries ship. This re-enables it for GA. It passes as-is: no rule or module changes were needed.Changes
./gradlew $GRADLE_ARGS proguard-tests:buildinscripts/build.shand drop theTODO(thatfiredev).CONTRIBUTING.mdand fourokf-bundle/docs so the documented step list, the known-trap entry and the module table match the script again.Why this is the only R8 coverage
Every library sets
isMinifyEnabled = falseand only declaresconsumerProguardFiles, so:proguard-testsis the one place R8 applies them. Verified sensitive: removing-dontwarn com.facebook.**fromauth-proguard.profailsminifyReleaseWithR8.Cost
builddepends oncheck, so the unit path now also runs:proguard-tests:lintReleaseplus lint analysis for its library dependencies, duplicating worklint.ymlalready does. A fully uncached run of the step measured under a minute. Worth knowing: a lint finding there abortsbuild.shbefore checkstyle and the unit tests.Maintainer note: Fixes internal CPRN-491