Conversation
…ery (#2497) * fix(auth): keep the session id when the continue URL already has a query * fix(auth): don't read a literal ? in a query value as an open query * fix(auth): percent-encode continue URL params by building through Uri * test(auth): pin the encoded form of a continue URL param value
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors ContinueUrlBuilder to use android.net.Uri instead of manual string manipulation for appending query parameters. This change ensures that parameters are properly percent-encoded and correctly appended regardless of whether the incoming URL already contains a query string or a fragment. Additionally, comprehensive unit tests have been added in ContinueUrlBuilderTest and EmailLinkParserTest to verify these behaviors and ensure robust parsing. There are no review comments, and I have no additional feedback to provide.
…2508) * fix(auth): build auth exceptions with the configured string provider * fix(auth): keep the dialog controller's auth-state lambda live across recompositions
…2509) * fix(auth): localize user-facing auth errors by Firebase error code * fix(auth): translate the strings left as English across 84 locales * fix(auth): stop auth errors leaking the Firebase SDK's English diagnostic * fix(auth): translate the password policy and passkey strings across 84 locales * test(auth): drop the bytecode sweep and tests that assert unreachable inputs * refactor(auth): derive the dismiss action from isRecoverable instead of duplicating it * fix(auth): use the credentials hook for expired user tokens, not the account-generic one * docs(auth): document how auth error messages resolve
* wip: demo (cherry picked from commit d88088103e61630c95f69de273953346b90486ab) * sample(auth): add MFA enrollment/challenge, reauth, and authenticated-state UI to full customization demo (cherry picked from commit 96694e0dddd4dacaa769d09ee153c34d4f51f8a2) * fix(sample): address review feedback on full customization demo Intercept back on the login/sign-up steps so it returns to email entry instead of leaving the auth flow, make the other-sign-in-methods sheet scrollable (nine providers plus the ToS footer overflow shorter screens), compare the confirmation email trimmed and case-insensitively and give the field an email keyboard, and take the configured FirebaseAuth instance rather than reaching for the global default. (cherry picked from commit 1dfdeda82ecce93f6af54f4dfd6371d108c0ca44) * sample(auth): drop recovery codes screen following its removal from MFA enrollment * sample(auth): label the two-factor CTA from the user's enrolled factors * sample(auth): migrate full customization reauth screen to ReauthContentState (cherry picked from commit 20681c413ada0394de19203bb2dde2784bac6d06) * sample(auth): render the demo's own email UI for library-initiated email flows * sample(auth): ask sign in or create account instead of probing for the account * sample(auth): carry the typed email into the next step and ungate create account * sample(auth): host the primary email flow on its own per-mode Navigation 3 back stack * sample(auth): match the swipe-back animation to the tapped one in the full-customization email flow * sample(auth): give reauthentication its own email step in the full-customization demo * sample(auth): route a returning email link to the demo that sent it * sample(auth): treat a declined reauthentication as a cancellation, not a failure * sample(auth): trim the demo's inline comments to one line each * sample(auth): let each demo own its email link tag and move the routing helpers out of MainActivity * sample(auth): drop the stale ContinueUrlBuilder rationale from the email link routing * sample(auth): tag the email link origin with a query param now that the continue URL builder preserves one * sample(auth): convert the full customization art to webp and stop lint failing on it * sample(auth): file the full customization art as nodpi instead of suppressing IconDensities * sample(auth): restore the emulator flag and label the phone entry CTA for what it does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.