fix: settings page crash on .map() of undefined#1
Merged
Conversation
…gins The server was emitting global_marketplaces_json/global_plugins_json (raw JSON strings) but the TypeScript client expected global_marketplaces/ global_plugins (parsed arrays). setMarketplaces(undefined) then caused ChipInput to call .map() on undefined. Fix both directions: - GET encoder now parses the stored JSON strings and emits proper arrays under the correct field names - PATCH handler now accepts arrays and JSON-encodes them before DB storage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of undefined (reading 'map')because the API returnedglobal_marketplaces_json/global_plugins_json(raw JSON strings) while the TypeScript client expectedglobal_marketplaces/global_plugins(parsed arrays)setMarketplaces(undefined)putundefinedinto state, thenChipInputcrashed calling.map()on it_json-suffixed string fields but the client sent arraysChanges
json/settings.gleam: encoder now parses the stored JSON strings and emits properstring[]arrays under the correct field nameshandlers/settings.gleam: PATCH decoder now acceptsList(String)arrays and JSON-encodes them before persistingTest plan
🤖 Generated with Claude Code