fix: settings page crash — align MCP server API field names#7
Open
fix: settings page crash — align MCP server API field names#7
Conversation
The McpServer JSON encoder emitted server_type/args_json/env_json (raw JSON strings) but the TypeScript client expected type/args/env (parsed array and object). When servers were returned, s.env was undefined and Object.keys(s.env) crashed in McpServerList. Fix both directions following the same pattern as the settings fix: - GET encoder now parses the stored JSON strings and emits proper array/object under the expected field names (type, args, env) - POST/PATCH handlers now accept array/object and JSON-encode them before DB storage Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_type/args_json/env_json(raw JSON strings), but the TypeScript client expectedtype/args(array) /env(object). When servers were returned,s.envwasundefinedandObject.keys(s.env)crashed inMcpServerList, breaking the Settings page.Test plan
gleam buildcleangleam test(pre-existing NIF-load failures only, unrelated)tsc -p tsconfig.web.json --noEmitcleanObject.keyscrash🤖 Generated with Claude Code