feat: capture fast_confirmation beacon-api event in sentry#829
Closed
samcm wants to merge 5 commits into
Closed
Conversation
Wires the new fast_confirmation SSE event from beacon-APIs#598 through the sentry pipeline. Adds the proto schema (xatu.eth.v1.EventFastConfirmation + BEACON_API_ETH_V1_EVENTS_FAST_CONFIRMATION enum), the sentry decorator and dedup cache, the server-side ingester handler, and an OnEvent tap that filters the raw event stream for fast_confirmation (the beacon library doesn't yet expose a typed OnFastConfirmation publisher). Triggered by adding fast_confirmation to ethereum.beaconSubscriptions in the sentry config; no other config required.
Adds //nolint:goconst on the duplicate-cache log field strings to match the rest of the event handlers, and drops the stale ethpandaops/go-eth2-client v0.1.2 entries from go.sum.
Adds the ClickHouse table, distributed view, and rowgen wiring so fast_confirmation events flow from Kafka through to ClickHouse via consumoor. Schema mirrors block_gossip. Also adds TestCompletenessEveryEventNameHasRoute which walks every xatu.Event_Name and asserts each is either routed or in an explicit allowlist with a justification. Trips on future enum additions that forget to wire a route.
Inlines the deprecated/_V2 justification string as a constant in the completeness allowlist and drops the redundant string() cast on the route.TableName() return (which already returns string). Adds nolint markers on the new fast_confirmation snapshot test fields to match the goconst posture in the sibling tests.
The original change appended the new local + distributed tables to 001_init.up.sql, but new tables go in their own numbered migration so the init bundle stays frozen. Adds 002_fast_confirmation.up.sql and the matching down migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the new
fast_confirmationSSE event from beacon-APIs#598 through the sentry pipeline. Adds the proto schema, sentry decorator, server-side ingester, and anOnEventtap that filters for the topic (the beacon library doesn't yet expose a typedOnFastConfirmationpublisher). Triggered by addingfast_confirmationtoethereum.beaconSubscriptions— no other config required.Depends on ethpandaops/go-eth2-client#24 (currently pinned to its commit via pseudo-version; will bump to a tag once that merges) and on #828 (swap-eth2-client-fork) being merged first.