feat: capture fast_confirmation beacon-api event in sentry#830
Merged
Conversation
Wires the new fast_confirmation SSE event (beacon-APIs#598) all the way through xatu: adds the proto schema, the sentry decorator + dedup cache, the server-side ingester registration, a tap on the raw event stream that decorates fast_confirmation messages (since ethpandaops/beacon doesn't yet expose a typed OnFastConfirmation), the ClickHouse table + distributed view as a new 002 migration, the consumoor rowgen and flatten logic, and a cross-cutting TestCompletenessEveryEventNameHasRoute that asserts every Event_Name has a route or an allowlisted reason. The slot field on the event is the confirmed block's slot (typically in the past), so wallclock_slot/wallclock_epoch are also populated from the sentry's wall clock, mirroring voluntary_exit. Triggered by adding fast_confirmation to ethereum.beaconSubscriptions in the sentry config. Depends on ethpandaops/go-eth2-client#24 (currently pinned via pseudo-version; bump to a tag once that merges).
Epoch 0 is genuine genesis data, not 'missing'. Sentinel-zero on optional derived columns conflated the two. Switch propagation_slot_start_diff, epoch, epoch_start_date_time, wallclock_slot/epoch and their *_start_date_time to Nullable so a real null can mean 'unknown'. slot_start_date_time stays non-null because it's in ORDER BY.
Member
Author
|
Codex review notes + follow-up:
Follow-up (separate PR): bump |
Pulls in ethpandaops/beacon#73 so the library handleEvent switch recognises fast_confirmation, eliminating per-event 'unknown event topic' errors when a sentry subscribes to the topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the new `fast_confirmation` SSE event from beacon-APIs#598 end-to-end: sentry decorator and dedup, server-side ingester, consumoor route + ClickHouse migration (`002_fast_confirmation`), and a cross-cutting completeness test that asserts every `Event_Name` is either routed or in an explicit allowlist with a justification. Slot on the event is the confirmed block's slot, so `wallclock_slot`/`wallclock_epoch` are populated from the sentry's wall clock (mirrors voluntary_exit).
Triggered by adding `fast_confirmation` to `ethereum.beaconSubscriptions`. Depends on ethpandaops/go-eth2-client#24 (pinned via pseudo-version; bump to a tag once that merges). Replaces #829 — that one auto-closed when its `swap-eth2-client-fork` base branch was deleted after #828 merged.