Repository navigation
fix: rebase teku master patch onto async gossip decoding - #13
Open
barnabasbusa wants to merge 1 commit into
Open
barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
This PR only rewrites patches/consensys/teku/master.patch: it re-indents the Eth2TopicHandler hunk context for the async-gossip change upstream and refreshes the affected index/hunk line numbers. I fetched every modified base file from Consensys/teku at the current master 10e03bc, confirmed each old blob hash in the patch matches, and git apply --check succeeds against that exact base; the resulting files' git blob hashes also match every new hash in the patch (including Eth2TopicHandler.java → 46809d7). The functional patch content is unchanged apart from indentation, so the rebase is correct and complete.
Reviewed 1 changed file(s) @ a4792d08 — no blocking issues found.
"Ship the prototype."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teku #11447 (Consensys-Incorporated/teku@f23ff0a) moved SSZ decoding in
Eth2TopicHandler.handleMessageonto the async runner and dropped the innerrunAsyncwrapper, somaster.patchno longer applies (3-way conflict) and both the daily patch check and the eth-client-docker-image-builderxatu-sidecar-masterteku build fail. This rebases the patch onto teku master10e03bc, moving theGossipMessageAcceptedEventpublishing into the newprocessor.process(...).thenApplycallback; the rest of the patch is unchanged apart from context. Verified it applies withscripts/apply-temu-patch.shon a fresh master clone and that:plugins:xatu,:networking:eth2,:services:beaconchainand:tekucompile.