Repository navigation
feat: re-enable teku xatu-sidecar scheduled build - #418
barnabasbusa wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Summary
The PR is a one-line revert of 0f420ce that re-adds teku to SIDECAR_VARIANTS, and with the current code it generates only the teku xatu-sidecar-master build (the devnet rule was already dropped in 1252e7c). The code path is correct, but it depends on an external fix that is not yet merged: temu#13 is still open, so merging this now re-enables the hourly scheduled teku xatu-sidecar-master build that will fail when the temu patch cannot be applied.
Issues
- 🔴
generate_config.py:75— Depends on still-open temu#13; scheduled build will fail as merged — see the thread on that line
Reviewed @ 418c3b13
"Premature abstraction is worse than premature optimization." — Sandi Metz, paraphrased
| # Clients that need to have xatu sidecar builds created automatically | ||
| SIDECAR_VARIANTS = [] | ||
| SIDECAR_VARIANTS = [ | ||
| 'teku' |
There was a problem hiding this comment.
🔴 Depends on still-open temu#13; scheduled build will fail as merged
gh pr view 13 --repo ethpandaops/temu reports temu#13 (fix: rebase teku master patch onto async gossip decoding) as OPEN, and its body states the current patches/consensys/teku/master.patch no longer applies after teku #11447, so xatu-sidecar-master fails. Adding teku back here makes .github/workflows/scheduled.yml regenerate config.yaml and run teku/xatu-sidecar.sh, which calls temu's patch script and exits non-zero on the failed apply — the hourly build stays red until temu#13 lands. Merge this only after temu#13 is merged.
Adds teku back to the scheduled xatu-sidecar builds (
xatu-sidecar-master), reverting 0f420ce. Do not merge before ethpandaops/temu#13 is merged: the current temu patch no longer applies to teku master after the async gossip decoding change, so the scheduled build would keep failing until the rebased patch lands.