refactor(tests): replace runtime skip in EIP-7778 calldata test#2852
Merged
Conversation
danceratopz
changed the base branch from
eips/amsterdam/eip-7778
to
forks/amsterdam
5 tasks
danceratopz
changed the title
…cell in `test_varying_calldata_costs` `STORAGE_CLEAR` refund is zero on revert, so `gas_used_pre_refund == gas_used_post_refund` and the `(post, pre)` interval that `DATA_FLOOR_BETWEEN_TX_GAS_BEFORE_AND_AFTER` requires is empty. Replace the runtime `pytest.skip()` with the `filter_combinations` marker introduced in ethereum#2543, which runs in `pytest_collection_modifyitems` and can express predicates across covariant-marker-injected and inline parametrize axes uniformly. Keeps `with_all_refund_types()` so new refund types added to the fork in future automatically participate, preserves the original three-decorator parametrize stack, and produces byte-identical fixture IDs and content vs the pre-refactor branch (verified via `diff` on `varying_calldata_costs.json` keys and bodies). The two infeasible items per fork are now deselected at collection time rather than skipped at runtime.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2852 +/- ##
================================================
Coverage 86.94% 86.94%
================================================
Files 586 586
Lines 35767 35767
Branches 3362 3362
================================================
Hits 31098 31098
Misses 4010 4010
Partials 659 659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR just refactors
test_varying_calldata_coststo avoid runtimepytest.skip()and avoid console noise by using thefilter_combinationsmarker from #2543.The
STORAGE_CLEARrefund is zero on revert, so the(post, pre)interval thatDATA_FLOOR_BETWEEN_TX_GAS_BEFORE_AND_AFTERrequires is empty; the two infeasible cells per fork are now deselected at collection time instead of at runtime.The
with_all_refund_types()covariant marker is retained so future refund types auto-participate.Fixtures are identical to the pre-refactor branch, verified by
uv run hasher compare.🔗 Related Issues or PRs
Follow-up review nit on #2840. Uses the
filter_combinationsmarker added by #2543.✅ Checklist
just statictype(scope):.