feat(spec-specs, spec-tests): add EIP-7778 block gas accounting without refunds

[LouisTsai-Csie]

🗒️ Description

Merge changes necessary for implementing EIP-7778 into the forks/amsterdam branch.

This PR targets the EIP-7778 spec from ethereum/EIPs@3929b1a.

🔗 Related Issues or PRs

• Tracking issue for EIP-7778 EIP-7778 Implementation Tracker: Block Gas Accounting without Refunds #1874
• Tracking issue for merging SFId EIPs SFI EIPs Merge to forks/amsterdam #2846

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (87c52b4) to head (9d88e40).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files

@@               Coverage Diff                @@
##           forks/amsterdam    #2840   +/-   ##
================================================
  Coverage            90.01%   90.01%           
================================================
  Files                  539      539           
  Lines                32618    32621    +3     
  Branches              3030     3030           
================================================
+ Hits                 29361    29364    +3     
  Misses                2699     2699           
  Partials               558      558           

Flag	Coverage Δ
unittests	90.01% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LouisTsai-Csie]

I want to do a follow-up PR to remove expected_benchmark_gas_used in BenchmarkTest. This is not required anymore, as we introduce expected_gas_used in BlockchainTest.

execution-specs/packages/testing/src/execution_testing/specs/benchmark.py

Line 302 in 87c52b4

env: Environment = Field(default_factory=Environment)

[LouisTsai-Csie]

Some missing cases that we could do as follow-up PRs:

• Refund tx OOG, revert the refund
• refund quauls/exceeds gas_used_pre_refund // max_refund_quotient
• storage x->y->0 refund (we have storage x->x->0 refund)
• behavior at fork transition
• successful at top frame but fails at subcall.
• delegate to a contract that does the storage refund (two refunds)
• authority do multiple authorization in same tx, resulting in cumulative refunds

[danceratopz]

Couple of small comments.

[danceratopz]

I think this is currently only a no-op. It only effects fill verification; the fixtures remain unchanged.

Suggested change

	},
	expected_receipt={
	"cumulative_gas_used": refund_tx_gas_used,
	},

The gas_used field does not exist in the transition tool:

execution-specs/src/ethereum/forks/amsterdam/blocks.py

Lines 347 to 382 in 9d88e40

	@slotted_freezable
	@dataclass
	class Receipt:
	"""
	Result of a transaction execution. Receipts are included in the receipts
	trie.
	"""
	succeeded: bool
	"""
	Whether the transaction execution was successful.
	"""
	cumulative_gas_used: Uint
	"""
	Total gas used in the block up to and including this transaction.
	This is the gas used after refunds, paid by the user.
	"""
	bloom: Bloom
	"""
	Bloom filter for logs generated by this transaction. This is a 2048-byte
	bit array that allows for efficient filtering of logs.
	"""
	logs: Tuple[Log, ...]
	"""
	A tuple of logs generated by this transaction. Each log contains the
	address of the contract that emitted it, a tuple of topics, and the data
	payload.
	"""
	def encode_receipt(tx: Transaction, receipt: Receipt) -> Bytes | Receipt:
	r"""
	Encodes a transaction receipt based on the transaction type.

This requires a follow-up issue to detect in the helper. I will follow-up.

[danceratopz]

Sorry the diff is off.

[LouisTsai-Csie]

I am not sure if i fully understand this issue, could you please create an issue for tracking?

[danceratopz]

Same issue here as above:

Suggested change

	expected_receipt={
	"gas_used": refund_tx_gas_used + extra_tx_intrinsic_gas_cost,
	},
	"cumulative_gas_used": (
	refund_tx_gas_used + extra_tx_intrinsic_gas_cost
	),