Skip to content

Introduced TypeScript (Part 2) - #1221

Open
ijlee2 wants to merge 6 commits into
introduce-typescript-part-1from
introduce-typescript-part-2
Open

Introduced TypeScript (Part 2)#1221
ijlee2 wants to merge 6 commits into
introduce-typescript-part-1from
introduce-typescript-part-2

Conversation

@ijlee2

@ijlee2 ijlee2 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Background

By using *.{gts,ts} files, we can provide linters like eslint, glint, and typescript more information and they can help us (maintainers and contributors) change code with more confidence.

What changed?

Continuation of #1220. To help document these files, I added types and tests when missing:

  • Acceptance tests
  • Adapters and their tests
  • Helpers and their tests
  • Models and their tests
  • Modifiers and their tests
  • Serializers and their tests
  • Services and their tests
  • Utilities and their tests

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

2/15 Files got Bigger 🚨:

Details
File raw gzip
chunk.120.js +366 kB +105 kB
chunk.876.js +12 kB +1.85 kB

1/15 Files got Smaller 🎉:

Details
File raw gzip
ember-website.js -544 B -124 B

2/15 Files got Deleted 🗑️:

Details
File raw gzip
chunk.309.js -365 kB -104 kB
chunk.324.js -11.9 kB -1.83 kB

10/15 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.328.js 0 B 0 B
chunk.524.js +1 B +2 B
chunk.582.js +1 B +1 B
chunk.633.js 0 B 0 B
chunk.96.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

Created by ember-asset-size-action

@ijlee2
ijlee2 marked this pull request as ready for review September 3, 2026 08:18
@ijlee2
ijlee2 force-pushed the introduce-typescript-part-1 branch from a7fce13 to a166e3f Compare September 3, 2026 08:25
@ijlee2
ijlee2 force-pushed the introduce-typescript-part-2 branch from 591be0e to 8c3f5e5 Compare September 3, 2026 08:27
@ijlee2
ijlee2 requested a review from a team September 3, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant