Introduced TypeScript (Part 1) - #1220
Open
ijlee2 wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
1/14 Files got Bigger 🚨: Details
1/14 Files got Smaller 🎉: Details
1/14 Files got Deleted 🗑️: Details
11/14 Files stayed the same size 🤷: Details
Created by ember-asset-size-action |
ijlee2
marked this pull request as ready for review
September 3, 2026 08:16
This was referenced Sep 3, 2026
ijlee2
force-pushed
the
introduce-typescript-part-1
branch
from
September 3, 2026 08:25
a7fce13 to
a166e3f
Compare
ijlee2
commented
Sep 3, 2026
| }); | ||
|
|
||
| assert.hasPageTitle('Legal - Ember.js'); | ||
| assertPageTitle(assert, 'Legal - Ember.js'); |
Member
Author
There was a problem hiding this comment.
It's easier to type a function than an overridden assert (and, at a later point, the delete assert statement).
ijlee2
commented
Sep 3, 2026
| ], | ||
| }); | ||
|
|
||
| // Q3.01: How many developers at your company are responsible for writing Front-End code? |
Member
Author
There was a problem hiding this comment.
I think it's okay to remove these data because the routes for past years are hidden (they can't be reached via the top navigation menu). If we keep these code around, some of the chart instances will result in a type error that needs to be fixed or ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
By using
*.{gts,ts}files, we can provide linters likeeslint,glint, andtypescriptmore information and they can help us (maintainers and contributors) change code with more confidence.What changed?
I refactored code (removed custom methods on
assert, unused code forsurveyroute templates, unnecessary controllers, and unnecessary helpers) so that it's easier to introduce types and review changes in #1221 and #1222.I recommend selecting the "Hide whitespace" option to review diffs.