Skip to content

Bump treesitter and rules_nodejs#5

Open
maan2003 wants to merge 4 commits into
elliottt:mainfrom
maan2003:main
Open

Bump treesitter and rules_nodejs#5
maan2003 wants to merge 4 commits into
elliottt:mainfrom
maan2003:main

Conversation

@maan2003

@maan2003 maan2003 commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

DISCLAIMER: I know nothing about bazel. This was just trial and error.

@elliottt

elliottt commented Jul 4, 2023

Copy link
Copy Markdown
Owner

Thanks so much for doing this upgrade! I'll have a look later today :)

@elliottt

elliottt commented Jul 6, 2023

Copy link
Copy Markdown
Owner

It looks like the tests are failing. You should be able to run them locally with:

bazelisk test --strategy=standalone --build_tests_only //tests

@kitterion

kitterion commented Oct 22, 2023

Copy link
Copy Markdown
Contributor

Hi, I'd love to see this merged since rules_tree_sitter currently don't work on darwin-arm64 or linux-arm64. What would be required to do that?
I have verified that reverting changes in the WORKSPACE file, but setting node_version to be at least 16.0.0 makes tests pass locally. 16.0.0 or higher is required because that is the first nodejs version with a darwin-arm64 build.

@elliottt

Copy link
Copy Markdown
Owner

Hi, I'd love to see this merged since rules_tree_sitter currently don't work on darwin-arm64 or linux-arm64. What would be required to do that? I have verified that reverting changes in the WORKSPACE file, but setting node_version to be at least 16.0.0 makes tests pass locally. 16.0.0 or higher is required because that is the first nodejs version with a darwin-arm64 build.

Thanks for checking this out! I'd be happy to merge this PR with fixes. Would you like to clone the branch and submit a new one? It would be great if we could retain @maan2003's contributions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants