Update tree-sitter to 0.20.8 and add arm64 platforms#8
Merged
Conversation
elliottt
approved these changes
Oct 31, 2023
elliottt
left a comment
Owner
There was a problem hiding this comment.
Thank you for pushing this across the finish line!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #5 with a few changes:
node_versionis now 16.9.1 which is the highest available on the 4.2.0 branch of rules_nodejs https://github.com/bazelbuild/rules_nodejs/blob/4.2.0/nodejs/private/node_versions.bzl#L1694. A version of at least 16.0.0 is needed, because that's when nodejs started including darwin-arm64 buildsuser_compile_flags = ["-Wno-unused-but-set-variable"]. It seems that the issue was fixed in the commit tree-sitter/tree-sitter@465ceea which is included in v0.20.8target_compatible_with = platforms. There's no need to restrict the toolchain like that,exec_compatible_withis enough.