Skip to content

refactor: remove SDKMAN, use system mvn + Maven Wrapper #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmanuelbruno merged 1 commit into from
Sep 24, 2026
Merged

refactor: remove SDKMAN, use system mvn + Maven Wrapper #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci-shareable-maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
# Setup maven version as a wrapper
- name: Setup Maven Wrapper
run: |
source "/home/runner/.sdkman/bin/sdkman-init.sh" && mvn ${{ inputs.maven-args }} wrapper:wrapper \
mvn ${{ inputs.maven-args }} wrapper:wrapper \
-Dmaven="${{ matrix.maven }}"

- name: Extract branch name
Expand All @@ -184,15 +184,15 @@ jobs:
# Build and test
- name: Build and Test with Maven
run: |
source "/home/runner/.sdkman/bin/sdkman-init.sh" && ./mvnw ${{ inputs.maven-args }} ${{ inputs.verify-goal }}
./mvnw ${{ inputs.maven-args }} ${{ inputs.verify-goal }}

# Check quality with SonarQube
### THIS STEP MUST BE ENABLED BY CONFIGURING:
### SONAR_URL and SONAR_TOKEN secrets.
- name: Quality check with Sonarqube
if: ${{ (inputs.quality-goal-run == 'true') && (env.SONAR_URL != null) && (env.SONAR_TOKEN != null) }}
run: |
source "/home/runner/.sdkman/bin/sdkman-init.sh" && ./mvnw ${{ inputs.maven-args }} ${{ inputs.quality-goal }}
./mvnw ${{ inputs.maven-args }} ${{ inputs.quality-goal }}

# Stage artifact to github
- name: Build artifacts archive
Expand All @@ -209,11 +209,11 @@ jobs:
- name: Deploy develop artefact
if: ${{ inputs.deploy-goal-run == 'true' && (github.ref_name != 'master') }}
run: |
source "/home/runner/.sdkman/bin/sdkman-init.sh" && ./mvnw ${{ inputs.maven-args }} ${{ inputs.deploy-goal-develop }} deploy
./mvnw ${{ inputs.maven-args }} ${{ inputs.deploy-goal-develop }} deploy
- name: Deploy release artefact
if: ${{ inputs.deploy-goal-run == 'true' && (github.ref_name == 'master') }}
run: |
source "/home/runner/.sdkman/bin/sdkman-init.sh" && ./mvnw ${{ inputs.maven-args }} ${{ inputs.deploy-goal-release }} deploy
./mvnw ${{ inputs.maven-args }} ${{ inputs.deploy-goal-release }} deploy

## Build and deploy project site
- name: Load SSH Key in agent
Expand All @@ -226,4 +226,4 @@ jobs:
run: |
mkdir -p ~/.ssh/ && touch ~/.ssh/known_hosts
ssh-keyscan github.com >> ~/.ssh/known_hosts
source "/home/runner/.sdkman/bin/sdkman-init.sh" && ./mvnw ${{ inputs.maven-args }} ${{ inputs.site-goal }}
./mvnw ${{ inputs.maven-args }} ${{ inputs.site-goal }}
Loading