refactor: remove SDKMAN, use system mvn + Maven Wrapper - #2
Merged
Merged
Conversation
The runner image now has Maven pre-installed (pinned, sha256-verified). This removes the SDKMAN source line from all steps: - 'Setup Maven Wrapper': uses system mvn (from runner image) - All build/deploy/quality steps: use ./mvnw (Maven Wrapper) Requires: runner image with Maven on PATH (see ebpro/quarkus-ci-runner)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Generic self-hosted runners may lack Maven on PATH, causing workflow failures.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Refactors the shared Maven workflow to remove SDKMAN and use system Maven with the Maven Wrapper.
Changes:
- Uses
mvnfromPATHto generate the wrapper. - Removes SDKMAN initialization from Maven commands.
- Relies on runner-provided Maven.
| File | Summary |
|---|---|
.github/workflows/ci-shareable-maven.yml |
Removes SDKMAN dependencies; currently requires Maven on PATH for all selected runners. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Setup Maven Wrapper | ||
| run: | | ||
| source "/home/runner/.sdkman/bin/sdkman-init.sh" && mvn ${{ inputs.maven-args }} wrapper:wrapper \ | ||
| mvn ${{ inputs.maven-args }} wrapper:wrapper \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all SDKMAN dependencies from the shared Maven workflow. The runner image now provides Maven directly (pinned, sha256-verified), making SDKMAN unnecessary.
Changes
source sdkman-init.sh && mvn wrapper:wrappermvn wrapper:wrappersource sdkman-init.sh && ./mvnw verify./mvnw verifyWhy
ebpro-orgK8s pod runners./mvnw) still ensures per-project Maven version consistencyBreaking change
Requires runner image with Maven on PATH. See companion PR:
ebpro/quarkus-ci-runner(adds Maven 3.9.11).Old runners with SDKMAN will still work (system mvn takes precedence, SDKMAN is simply not sourced).