fix(generate): fail the run when the permissions feature errors - #2550
Merged
Conversation
With a malformed .vibe/config.toml, --features mcp exited 1 while --features permissions swallowed the same parse failure with a warning and reported 'All files are up to date' - a silent false-success where the user's permission changes were not applied and nothing signaled it. The permissions loop now logs at error level and rethrows, matching the MCP feature's behavior on the same file. Regression coverage: an e2e case asserts both features exit 1 on the same malformed fixture, and the generate unit test that pinned the old swallow-and-continue behavior now pins the fail-the-run behavior. Closes #2486 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2486: with a malformed
.vibe/config.tomlon disk,generate --features mcpexited 1 with a parse error while--features permissionsswallowed the same failure (logger.warn+continueingeneratePermissionsCore) and exited 0 reporting "All files are up to date" — a silent false-success.it.eachasserts both features exit 1 on the same malformed fixture, and the generate unit test that pinned the old swallow-and-continue behavior now pins fail-the-run.Testing
pnpm cicheckgreen; targeted e2e cases pass locally.Closes #2486
🤖 Generated with Claude Code