fix(generate): fail the run when the ignore feature errors - #2552
Merged
Conversation
generateIgnoreCore was the last feature loop still swallowing per-target errors (warn + continue, exit 0 'All files are up to date'). Ignore files are what keep secrets out of AI tools' reach, so a silently-skipped ignore generation is the same fail-open bug the permissions feature had; it now logs at error level and rethrows, matching every other feature core, and the pinning unit test flips to fail-the-run. Closes #2551 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The generateCommand-level tests still pinned the swallowed-error behavior; they now assert the command rejects and no success banner is emitted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ules never run Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
@dyoshikawa Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2551 (follow-up from the PR #2550 review):
generateIgnoreCorewas the last feature loop still swallowing per-target errors with warn +continue, exiting 0 with "All files are up to date" — including in--checkmode — while nothing was written. Since ignore files are what keep secrets out of AI tools' reach, this was the same fail-open class as #2486's permissions bug, arguably worse.Testing
pnpm cicheckgreen.Closes #2551
🤖 Generated with Claude Code