Revert Input Screen return button behavior #7537
Merged
+55
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/InputModeWidget.kt
Show resolved
Hide resolved
joshliebe
merged commit 55f3426
into
feature/josh/update-input-screen-ui
20 of 21 checks passed
joshliebe
added a commit
that referenced
this pull request
Jan 20, 2026
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1212864806121264?focus=true ### Description - Adds the return button back to Duck.ai tab and sets the keyboard action to submit. ### Steps to test this PR - [ ] Open in the Input Screen - [ ] Go to Duck.ai tab and type something - [ ] Verify that the return button works as expected - [ ] Repeat above steps with bottom address bar enabled ### UI changes | Top address bar | Bottom address bar | | ------ | ----- | <img width="1280" height="2856" alt="Screenshot_20260120_130726" src="https://github.com/user-attachments/assets/b3002224-05bf-4394-a956-edbcf5093988" />|<img width="1280" height="2856" alt="Screenshot_20260120_130700" src="https://github.com/user-attachments/assets/de52bec1-c19d-4c13-afab-de0bef3429be" /> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces an explicit multiline entry control and ties it into visibility/state and telemetry. > > - Adds `actionNewLine` button to `view_input_screen_buttons.xml` and `InputScreenButtons`, with floating styling, click handler, and visibility control > - Extends `InputScreenVisibilityState` with `newLineButtonVisible` and includes it in `actionButtonsContainerVisible`; `InputScreenViewModel` sets it (true in chat, based on text) and clears it in search > - Wires `onNewLineClick` in `InputScreenFragment` to `InputModeWidget.printNewLine()` and fires `DUCK_CHAT_EXPERIMENTAL_OMNIBAR_FLOATING_RETURN_PRESSED` > - Implements `printNewLine()` in `InputModeWidget` and changes chat `imeOptions` to `IME_ACTION_GO` > - Updates button container visibility logic to account for the new button; minor visibility tweaks (e.g., send button default to `gone`) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d58c840. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1212864806121264?focus=true
Description
Steps to test this PR
UI changes
Note
Introduces an explicit multiline entry control and ties it into visibility/state and telemetry.
actionNewLinebutton toview_input_screen_buttons.xmlandInputScreenButtons, with floating styling, click handler, and visibility controlInputScreenVisibilityStatewithnewLineButtonVisibleand includes it inactionButtonsContainerVisible;InputScreenViewModelsets it (true in chat, based on text) and clears it in searchonNewLineClickinInputScreenFragmenttoInputModeWidget.printNewLine()and firesDUCK_CHAT_EXPERIMENTAL_OMNIBAR_FLOATING_RETURN_PRESSEDprintNewLine()inInputModeWidgetand changes chatimeOptionstoIME_ACTION_GOgone)Written by Cursor Bugbot for commit d58c840. This will update automatically on new commits. Configure here.