-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Input Screen UI #7494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Input Screen UI #7494
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
215ff2c to
b552ec1
Compare
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
...impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/SwipeableRecyclerView.kt
Show resolved
Hide resolved
b552ec1 to
8ccbf46
Compare
...hat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/tabs/SearchTabFragment.kt
Show resolved
Hide resolved
46f6942 to
e79da03
Compare
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
e79da03 to
94b1dde
Compare
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
94b1dde to
8db9698
Compare
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
...hat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/tabs/SearchTabFragment.kt
Show resolved
Hide resolved
8db9698 to
95f38c1
Compare
...kchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/InputModeWidget.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/view/TouchThroughNestedScrollView.kt
Show resolved
Hide resolved
95f38c1 to
72d756a
Compare
51371a9 to
3c05f30
Compare
malmstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, works as expected!
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1212864806121264?focus=true ### Description - Adds the return button back to Duck.ai tab and sets the keyboard action to submit. ### Steps to test this PR - [ ] Open in the Input Screen - [ ] Go to Duck.ai tab and type something - [ ] Verify that the return button works as expected - [ ] Repeat above steps with bottom address bar enabled ### UI changes | Top address bar | Bottom address bar | | ------ | ----- | <img width="1280" height="2856" alt="Screenshot_20260120_130726" src="https://github.com/user-attachments/assets/b3002224-05bf-4394-a956-edbcf5093988" />|<img width="1280" height="2856" alt="Screenshot_20260120_130700" src="https://github.com/user-attachments/assets/de52bec1-c19d-4c13-afab-de0bef3429be" /> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces an explicit multiline entry control and ties it into visibility/state and telemetry. > > - Adds `actionNewLine` button to `view_input_screen_buttons.xml` and `InputScreenButtons`, with floating styling, click handler, and visibility control > - Extends `InputScreenVisibilityState` with `newLineButtonVisible` and includes it in `actionButtonsContainerVisible`; `InputScreenViewModel` sets it (true in chat, based on text) and clears it in search > - Wires `onNewLineClick` in `InputScreenFragment` to `InputModeWidget.printNewLine()` and fires `DUCK_CHAT_EXPERIMENTAL_OMNIBAR_FLOATING_RETURN_PRESSED` > - Implements `printNewLine()` in `InputModeWidget` and changes chat `imeOptions` to `IME_ACTION_GO` > - Updates button container visibility logic to account for the new button; minor visibility tweaks (e.g., send button default to `gone`) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d58c840. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
55f3426 to
be11ae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
...ckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenFragment.kt
Show resolved
Hide resolved
0fecb50 to
516d897
Compare

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212823503385852?focus=true
Description
Steps to test this PR
UI changes
Duck.ai tab

Duck.ai tab (Bottom address bar)

Duck.ai tab (Input expanded)

Duck.ai tab (Input expanded with bottom address bar)

Note
Modernizes Input Screen interactions and layout.
autoCompleteOverlayandnewTabContainerScrollViewfor autocomplete and favorites with fade/slide transitions, elevation, and rootChangeBoundstransitions; disablesViewPager2input while overlays are shown.SwipeableRecyclerViewandTouchThroughNestedScrollViewto pass horizontal swipes toViewPager2while preserving vertical scroll/click, including synthetic DOWN dispatch.SearchTabFragmentdelegates UI containers to parentInputScreenFragment, applies blur on autocomplete, and usesSwipeableRecyclerView.pressKey: Enterin flow.Written by Cursor Bugbot for commit 516d897. This will update automatically on new commits. Configure here.