Skip to content

SCRIP-SITE-007: readable offline full-work diagnostic reports - #268

Merged
andy-zen-dev merged 2 commits into
masterfrom
scrip-site-007-frozen-diagnostic-report
Oct 18, 2026
Merged

andy-zen-dev merged 2 commits into
masterfrom
scrip-site-007-frozen-diagnostic-report

Conversation

@andy-zen-dev

Copy link
Copy Markdown
Collaborator

Closes #267.

Product change

Generate a readable standalone HTML report from the existing source-free frozen diagnostic:

python -m scriptorium.frozen_diagnostic_report \
  benchmarks/fantlab/work270306-wikisource-diagnostic.json \
  --title "Anna Karenina — full-work diagnostic" \
  --output anna-diagnostic.html

The report shows all 28 historical rows (23 numeric actuals, five missing), units, expected/actual/raw delta, grouped families and replay identities. Missing is not zero. Omitted families, observations and M2 status are explicitly historical, not a new replay or current provider-status claim.

Safety / correctness

  • Reject schema/field drift, duplicate JSON keys, malformed status types, non-finite/out-of-range numbers, inconsistent deltas, pass/fail promotion and source-text/source-match gate changes.
  • Preserve integer precision above 2^53 and small nonzero deltas; floating arithmetic consistency is not a parity tolerance.
  • Offline, escaped HTML with captioned tables, keyboard-scrollable regions, skip link, visible focus and responsive styling. Create-only output preserves existing reports.
  • No changes to historical benchmark bytes, analyzer formulas, corpus admission, morphology, science gates, workflow permissions or Pages activation.
  • Add a README example and documentation; reconcile the Oct 2 owner direction into the existing compact queue rather than creating another control plane.

Executed verification

  • Local focused module suite: 23/23 PASS, including exact canonical diagnostic blob 0d5e420abb45e2b9e178df75a479ab7cdd5a4150.
  • Compile checks and real canonical JSON → HTML CLI: PASS.
  • Uploaded module/test blobs exactly match the tested local bytes: eade9e09e6e7ba0efe81144c91c9710849dc3654 / cf688a44dd26f2afad71b0cbf2e6e8e974a14401.
  • Full canonical suite was NOT_RUN locally: the execution container has only the verified subset; unauthenticated repository clone failed DNS. The existing Pages PR workflow runs the full suite and deterministic site rebuild at the exact PR head.
  • VISUAL_NOT_VERIFIED: Chromium launched, but navigation to the generated local HTML returned net::ERR_BLOCKED_BY_ADMINISTRATOR. No browser restriction was bypassed. Structural accessibility/escaping tests are not screenshot evidence.

Acceptance boundary

This is a code-authoring run; do not merge this semantic change in the same run. A later fresh acceptance must inspect the exact head, code/context, discussions and applicable CI. No GitHub self-approval is requested.

This PR supplies the standalone report, not a live Pages route. Next SCRIP-SITE-008 must reuse/revalidate these primitives and test actual integration: the old local patcher had an indentation defect despite its string-only self-test passing. #266 is already merged and is not a dependency/blocker.

Refs #267. Preserve historical source-unmatched evidence, add 23 regressions,
and restore a compact delivery-first product queue without changing science gates.

Copy link
Copy Markdown
Collaborator Author

Exact-head verification update for 5ad1ec9e80336546cb214fcb907a1d5bc59ec4b9:

  • All 22 returned PR-triggered workflow runs completed success.
  • Pages run 37450729048, job 112226385311, checked out that exact SHA. Read the actual job log: 651 tests passed, including all 23 new report tests, on CPython 3.13.15.
  • Canonical static build, byte-identical rebuild, symlink check and Pages-artifact upload all passed. Deploy was correctly skipped on this PR; this does not publish the new standalone report as a Pages route.
  • Changed-file readback confirms six intended files only. README is an 18-line additive example; retained corpus/science invariants are untouched by queue reconciliation. Tested module/test blob hashes match the committed files.
  • Browser visual verification remains blocked by net::ERR_BLOCKED_BY_ADMINISTRATOR on local-file navigation; no screenshot or live verification is claimed.

Ready for a later fresh acceptance on the then-current head/base/checks. Not merged or self-approved in this authoring run.

andy-zen-dev commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owner-requested delivery pass (2026-10-07), completed repair:

  • Found the four missing word/sentence unit denominators at 5ad1ec9e80336546cb214fcb907a1d5bc59ec4b9; fixed in this same PR branch at 50fbb9b9c0da59a5eb78c6826381b8acd3dd8aae using a non-forced expected-head update.
  • Explicit mappings for the four canonical mean-length IDs; three added regression tests cover those units, unchanged control units and the real 28-row historical artifact. Historical diagnostic blob 0d5e420abb45e2b9e178df75a479ab7cdd5a4150 is unchanged. No analyzer formulas, source text or science gates changed.
  • Exact-head hosted verification: all 22 returned PR-triggered workflow runs completed successfully. Pages run 37616533562, job 112776103132, checked out the fixed SHA and passed 654 tests, canonical site build, byte-identical rebuild and artifact upload. Deploy was skipped on the PR, not passed/live.
  • This run materially fixed the change, so it is not a merge-acceptance run and no self-approval/merge was performed. A later fresh acceptance can review the then-current head, base, discussions and applicable checks.
  • SCRIP-SITE-008: canonical full-work report and reader-first homepage #272 now contains the scoped site integration stacked on this exact corrected head. Do not merge SCRIP-SITE-008: canonical full-work report and reader-first homepage #272 into this feature branch; merge this PR after qualifying acceptance, then retarget/reconcile SCRIP-SITE-008: canonical full-work report and reader-first homepage #272 to master. SCRIP-METRIC-003: private local analysis with JSON and offline HTML #270 is an independent local-analysis feature and need not wait on this stack.

Refs #267. Add focused unit-label regressions and verify the canonical
28-row artifact remains byte-identical. No analyzer or parity changes.
andy-zen-dev added a commit that referenced this pull request Oct 7, 2026
… site

Refs #271. Add a digest-bound report adapter, one allow-listed route,
reader-first homepage and keyboard/mobile structure. Preserve all existing
source artifacts and science gates; add 15 integration regressions and
reconcile the existing delivery queue. Depends on #268.

@andy-zen-dev andy-zen-dev left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner-requested review of exact head 50fbb9b.

Reviewed the standalone renderer/validator, corrected mean-length units, README/docs and queue changes. The historical 28-row artifact remains source-unmatched; unknown values, integer deltas, escaping and scientific labels are preserved. Current provider read returns 22/22 successful PR workflow runs; no inline review threads exist. The earlier unit-denominator finding is fixed.

No new blocking defect found in the curated-artifact rendering path. CLI follow-up: main() still uses unbounded read_text and raw exception messages; keep input curated and adopt the common bounded/path-private I/O when integrating the reader commands. Visual acceptance is still NOT_RUN, not implied by structural tests or CI. This PR alone does not add a Pages route.

The owner requested one new integration PR against master. Preserve this implementation and #267 as provenance there; do not reimplement the report or close this PR before the integration is accepted. COMMENT-only solo review: no self-approval and no merge performed.

@andy-zen-dev
andy-zen-dev merged commit 6338bed into master Oct 18, 2026
26 checks passed
andy-zen-dev added a commit that referenced this pull request Oct 18, 2026
Later owner-requested acceptance after #268 merged. Retargeted to master; compare confirms master 6338bed has exactly the old base 50fbb9b tree, so this preserves the reviewed eight-file semantic diff. Reviewed renderer, digest-pinned adapter, manifest, safety and link tests, docs and queue. Fresh exact-head provider read: 22/22 PR workflow runs successful; no inline threads or blocking review findings. No new code authored in this acceptance. Static build is not Pages deployment; visual navigation remains unverified. Source-free snapshots and all science gates remain unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCRIP-SITE-007: deliver a readable frozen full-work diagnostic report

1 participant