Repository navigation
SCRIP-SITE-007: readable offline full-work diagnostic reports - #268
Conversation
Refs #267. Preserve historical source-unmatched evidence, add 23 regressions, and restore a compact delivery-first product queue without changing science gates.
|
Exact-head verification update for
Ready for a later fresh acceptance on the then-current head/base/checks. Not merged or self-approved in this authoring run. |
|
Owner-requested delivery pass (2026-10-07), completed repair:
|
Refs #267. Add focused unit-label regressions and verify the canonical 28-row artifact remains byte-identical. No analyzer or parity changes.
andy-zen-dev
left a comment
There was a problem hiding this comment.
Owner-requested review of exact head 50fbb9b.
Reviewed the standalone renderer/validator, corrected mean-length units, README/docs and queue changes. The historical 28-row artifact remains source-unmatched; unknown values, integer deltas, escaping and scientific labels are preserved. Current provider read returns 22/22 successful PR workflow runs; no inline review threads exist. The earlier unit-denominator finding is fixed.
No new blocking defect found in the curated-artifact rendering path. CLI follow-up: main() still uses unbounded read_text and raw exception messages; keep input curated and adopt the common bounded/path-private I/O when integrating the reader commands. Visual acceptance is still NOT_RUN, not implied by structural tests or CI. This PR alone does not add a Pages route.
The owner requested one new integration PR against master. Preserve this implementation and #267 as provenance there; do not reimplement the report or close this PR before the integration is accepted. COMMENT-only solo review: no self-approval and no merge performed.
Later owner-requested acceptance after #268 merged. Retargeted to master; compare confirms master 6338bed has exactly the old base 50fbb9b tree, so this preserves the reviewed eight-file semantic diff. Reviewed renderer, digest-pinned adapter, manifest, safety and link tests, docs and queue. Fresh exact-head provider read: 22/22 PR workflow runs successful; no inline threads or blocking review findings. No new code authored in this acceptance. Static build is not Pages deployment; visual navigation remains unverified. Source-free snapshots and all science gates remain unchanged.
Closes #267.
Product change
Generate a readable standalone HTML report from the existing source-free frozen diagnostic:
python -m scriptorium.frozen_diagnostic_report \ benchmarks/fantlab/work270306-wikisource-diagnostic.json \ --title "Anna Karenina — full-work diagnostic" \ --output anna-diagnostic.htmlThe report shows all 28 historical rows (23 numeric actuals, five missing), units, expected/actual/raw delta, grouped families and replay identities. Missing is not zero. Omitted families, observations and M2 status are explicitly historical, not a new replay or current provider-status claim.
Safety / correctness
Executed verification
0d5e420abb45e2b9e178df75a479ab7cdd5a4150.eade9e09e6e7ba0efe81144c91c9710849dc3654/cf688a44dd26f2afad71b0cbf2e6e8e974a14401.net::ERR_BLOCKED_BY_ADMINISTRATOR. No browser restriction was bypassed. Structural accessibility/escaping tests are not screenshot evidence.Acceptance boundary
This is a code-authoring run; do not merge this semantic change in the same run. A later fresh acceptance must inspect the exact head, code/context, discussions and applicable CI. No GitHub self-approval is requested.
This PR supplies the standalone report, not a live Pages route. Next SCRIP-SITE-008 must reuse/revalidate these primitives and test actual integration: the old local patcher had an indentation defect despite its string-only self-test passing. #266 is already merged and is not a dependency/blocker.