Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cpp/src/gandiva/engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,11 @@ static void OptimizeModuleWithNewPassManager(llvm::Module& module,
llvm::FunctionPassManager function_pm;
function_pm.addPass(llvm::InstCombinePass());
function_pm.addPass(llvm::PromotePass());
function_pm.addPass(llvm::GVNPass());
// NewGVN subsumes the legacy GVN; running both back to back just repeats the
// analysis. SLPVectorizer plus the O3 default pipeline's own loop vectorization
// cover vectorization, so the extra LoopVectorizePass here is redundant too.
function_pm.addPass(llvm::NewGVNPass());
function_pm.addPass(llvm::SimplifyCFGPass());
function_pm.addPass(llvm::LoopVectorizePass());
function_pm.addPass(llvm::SLPVectorizerPass());
module_pm.addPass(llvm::createModuleToFunctionPassAdaptor(std::move(function_pm)));

Expand All @@ -554,10 +555,10 @@ static void OptimizeModuleWithLegacyPassManager(llvm::Module& module,
pass_manager->add(llvm::createFunctionInliningPass());
pass_manager->add(llvm::createInstructionCombiningPass());
pass_manager->add(llvm::createPromoteMemoryToRegisterPass());
pass_manager->add(llvm::createGVNPass());
// NewGVN subsumes the legacy GVN, and SLPVectorizer plus the O3 pipeline cover
// vectorization, so the duplicate GVN and LoopVectorize passes are dropped.
pass_manager->add(llvm::createNewGVNPass());
pass_manager->add(llvm::createCFGSimplificationPass());
pass_manager->add(llvm::createLoopVectorizePass());
pass_manager->add(llvm::createSLPVectorizerPass());
pass_manager->add(llvm::createGlobalOptimizerPass());

Expand Down
Loading