Repository navigation
Conversation
lriggs
force-pushed
the
gandiva-trim-redundant-passes
branch
from
November 14, 2026 01:06
5da6745 to
5e5f3cc
Compare
The custom pass list added before the O3 default pipeline ran two global value numbering passes back to back (the legacy GVNPass and NewGVNPass) and an extra LoopVectorizePass. NewGVN subsumes the legacy GVN, and SLPVectorizer together with the O3 default pipeline's own vectorization already cover vectorization, so the duplicate GVN and the extra LoopVectorize are wasted compile time. Drop both in the new and legacy pass-manager paths. Generated code is unchanged (the surviving passes cover the same optimizations); only compile time drops (~8-12% on uncached compiles in local measurement).
lriggs
force-pushed
the
gandiva-trim-redundant-passes
branch
from
November 14, 2026 01:15
5e5f3cc to
113133f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom pass list added before the O3 default pipeline ran two global value numbering passes back to back (the legacy GVNPass and NewGVNPass) and an extra LoopVectorizePass. NewGVN subsumes the legacy GVN, and SLPVectorizer together with the O3 default pipeline's own vectorization already cover vectorization, so the duplicate GVN and the extra LoopVectorize are wasted compile time.
Drop both in the new and legacy pass-manager paths. Generated code is unchanged (the surviving passes cover the same optimizations); only compile time drops (~8-12% on uncached compiles in local measurement).