Skip to content

Align Chisel versions and download URLs during dependency updates #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbussell merged 1 commit into from
Oct 9, 2026
Merged

Align Chisel versions and download URLs during dependency updates #7404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions eng/update-dependencies/Updaters/ChiselUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ namespace Microsoft.DotNet.Docker.UpdateDependencies.Updaters;

public sealed class ChiselUpdater(IReleasesClient releases, HttpClient httpClient) : IGitHubReleaseUpdater
{
private const string BuildVersionVariable = "chisel|latest|build-version";
private const string Owner = "canonical";
private const string Repo = "chisel";

Expand All @@ -23,6 +24,12 @@ private static string GetChiselManifestVariable(string product, string arch, str

private static Regex GetAssetRegex(string arch) => new(@"chisel_v\d+\.\d+\.\d+_linux_" + arch + @"\.tar\.gz");

private static string GetDownloadUrl(string arch)
{
string buildVersion = $"$({BuildVersionVariable})";
return $"https://github.com/{Owner}/{Repo}/releases/download/{buildVersion}/chisel_{buildVersion}_linux_{arch}.tar.gz";
}

private static string ToManifestArch(string arch) => arch == "amd64" ? "x64" : arch;

public async Task<DependencyUpdate> ResolveFromGitHubReleaseAsync(CancellationToken cancellationToken)
Expand All @@ -39,13 +46,20 @@ private async Task ApplyAsync(
Release release,
CancellationToken cancellationToken)
{
if (!variables.ShouldUpdateLiteral(BuildVersionVariable))
{
return;
}

variables.SetValue(BuildVersionVariable, release.TagName);

foreach (string arch in s_supportedArchitectures)
{
string urlVariable = GetChiselManifestVariable(Name, arch, "url");
string shaVariable = GetChiselManifestVariable(Name, arch, "sha384");
bool updateUrl = variables.ShouldUpdateLiteral(urlVariable);
bool updateSha = variables.ShouldUpdateLiteral(shaVariable);
if (!updateUrl && !updateSha)
variables.SetValue(urlVariable, GetDownloadUrl(arch));

if (!variables.ShouldUpdateLiteral(shaVariable))
{
continue;
}
Expand All @@ -54,20 +68,12 @@ private async Task ApplyAsync(
ReleaseAsset asset = release.Assets.FirstOrDefault(asset => assetRegex.IsMatch(asset.Name))
?? throw new InvalidOperationException($"Could not find Chisel release asset matching regex {assetRegex}.");

if (updateUrl)
{
variables.SetValue(urlVariable, asset.BrowserDownloadUrl);
}

if (updateSha)
{
string checksumUrl = $"{asset.BrowserDownloadUrl}.sha384";
string content = await httpClient.GetStringAsync(checksumUrl, cancellationToken);
string checksumUrl = $"{asset.BrowserDownloadUrl}.sha384";
string content = await httpClient.GetStringAsync(checksumUrl, cancellationToken);

// Each checksum file contains "<sha384> <archive name>".
string sha = content.Split(" ")[0].ToLowerInvariant();
variables.SetValue(shaVariable, sha);
}
// Each checksum file contains "<sha384> <archive name>".
string sha = content.Split(" ")[0].ToLowerInvariant();
variables.SetValue(shaVariable, sha);
}
}
}
Loading