Skip to content

Changes failed Graph batch response to 200 OK. Closes #1358 #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 2 commits into from
Aug 13, 2025
Merged

Changes failed Graph batch response to 200 OK. Closes #1358 #1359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31d9f8
Changes failed Graph batch response to 200 OK. Closes #1358
waldekmastykarz Aug 12, 2025
5bb7a41
Merge branch 'main' into fix-graphrandomerror-424
waldekmastykarz Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DevProxy.Abstractions/Models/GraphBatchRequestPayload.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class GraphBatchRequestPayload
public class GraphBatchRequestPayloadRequest
{
public object? Body { get; set; }
public IEnumerable<string>? DependsOn { get; set; }
#pragma warning disable CA2227
Comment thread
waldekmastykarz marked this conversation as resolved.
public Dictionary<string, string>? Headers { get; set; } = [];
#pragma warning restore CA2227
Expand Down
10 changes: 7 additions & 3 deletions DevProxy.Plugins/Behavior/GraphRandomErrorPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,12 @@ private void FailBatch(ProxyRequestArgs e)
try
{
// pick a random error response for the current request method
// if the request has dependencies, use FailedDependency status code
// https://learn.microsoft.com/en-us/graph/json-batching?tabs=http#sequencing-requests-with-the-dependson-property
var methodStatusCodes = _methodStatusCode[request.Method];
var errorStatus = methodStatusCodes[_random.Next(0, methodStatusCodes.Length)];
var errorStatus = request.DependsOn is not null && request.DependsOn.Any() ?
HttpStatusCode.FailedDependency :
methodStatusCodes[_random.Next(0, methodStatusCodes.Length)];

var response = new GraphBatchResponsePayloadResponse
{
Expand Down Expand Up @@ -315,8 +319,8 @@ private void UpdateProxyResponse(ProxyRequestArgs e, HttpStatusCode errorStatus)

private void UpdateProxyBatchResponse(ProxyRequestArgs ev, GraphBatchResponsePayload response)
{
// failed batch uses a fixed 424 error status code
var errorStatus = HttpStatusCode.FailedDependency;
// failed batch uses 200 OK status code
var errorStatus = HttpStatusCode.OK;

var session = ev.Session;
var requestId = Guid.NewGuid().ToString();
Expand Down