Changes failed Graph batch response to 200 OK. Closes #1358 - #1359
Merged
waldekmastykarz merged 2 commits intoAug 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Graph batch error handling in the GraphRandomErrorPlugin to follow Microsoft Graph API batch request specifications. The changes ensure that failed batch responses return HTTP 200 OK status codes while individual batch items can still contain error information, and adds support for dependency-aware error handling.
Key changes:
- Updates failed batch responses to return HTTP 200 OK instead of HTTP 424 Failed Dependency
- Adds support for the
DependsOnproperty in batch request payloads - Implements logic to use FailedDependency status for requests with dependencies
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DevProxy.Plugins/Behavior/GraphRandomErrorPlugin.cs | Updates batch error handling logic to return 200 OK for failed batches and adds dependency-aware error status selection |
| DevProxy.Abstractions/Models/GraphBatchRequestPayload.cs | Adds DependsOn property to support Graph batch request dependencies |
garrytrinder
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes failed Graph batch response to 200 OK. Closes #1358