Create main function in entrypoint + rename entrypoint#26
Merged
Conversation
AbcSxyZ
changed the title
Member
|
I was just working on fixing python lint suggestions and these were findings there... I'll rebase mine on top of yours. |
patricklodder
previously approved these changes
Dec 4, 2021
patricklodder
left a comment
patricklodder
left a comment
Member
There was a problem hiding this comment.
ACK - code reviewed & tested to work on x86_64
patricklodder
self-requested a review
December 4, 2021 16:41
patricklodder
requested changes
Dec 4, 2021
patricklodder
left a comment
patricklodder
left a comment
Member
There was a problem hiding this comment.
When rebasing my lint fixes on top of this, I found that the second commit overwrites the first commit's changes.
Contributor
Author
|
Yep, commit troubles... Fixed. |
patricklodder
self-requested a review
December 4, 2021 18:44
patricklodder
approved these changes
Dec 4, 2021
patricklodder
left a comment
patricklodder
left a comment
Member
There was a problem hiding this comment.
ACK - code reviewed and tested on x86_64, again 😁
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a main function to call in entrypoint + rename
docker-entrypoint.pyFacilitate import of entrypoint for test coverage in #25.