Skip to content

Remove arguments from environment variables#27

Merged
patricklodder merged 1 commit into
dogecoin:mainfrom
AbcSxyZ:environ-fix
Dec 4, 2021
Merged

Remove arguments from environment variables#27
patricklodder merged 1 commit into
dogecoin:mainfrom
AbcSxyZ:environ-fix

Conversation

@AbcSxyZ

@AbcSxyZ AbcSxyZ commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

Reimplement #10 which have been removed by #11, merged without rebase.

@patricklodder

Copy link
Copy Markdown
Member

merged without rebase.

Github should have given a merge issue then (but I didn't force merge.)

I will enforce rebase as a rule as soon as the CI from #23 is in.

@patricklodder patricklodder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - code reviewed and tested on x86_64

@patricklodder

Copy link
Copy Markdown
Member

I'm merging this one now since we already ACK'd on #10, and explicitly before #26 because that needs to be reworked.

@patricklodder
patricklodder merged commit 6e9d7b0 into dogecoin:main Dec 4, 2021
@AbcSxyZ
AbcSxyZ deleted the environ-fix branch December 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants