Skip to content

QA-8695 Update Connect Toolbar Title When Leaving Delivery Screens #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OrangeAndGreen merged 1 commit into from
Oct 13, 2026
Merged

QA-8695 Update Connect Toolbar Title When Leaving Delivery Screens #3963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/org/commcare/activities/connect/ConnectActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ public void onPostCreate(@Nullable Bundle savedInstanceState) {
getSupportActionBar().setTitle(getString(R.string.connect_title));
}

@Override
public void setTitle(CharSequence title) {
super.setTitle(title);
setActionBarTitle(title);
}

@Override
protected void onResume() {
super.onResume();
Expand Down
14 changes: 14 additions & 0 deletions app/unit-tests/src/org/commcare/fragments/connect/ConnectDeliveryHomeFragmentTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import org.commcare.views.connect.ConnectCtaBar
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Rule
Expand Down Expand Up @@ -213,6 +214,19 @@ class ConnectDeliveryHomeFragmentTest {
)
}

@Test
fun `a later screen's title replaces the delivery title and subtitle`() {
every { job.title } returns "Delivery Opportunity"
val activity = launchHome().requireActivity() as ConnectActivity
val actionBar = activity.supportActionBar!!
assertEquals("Delivery Opportunity", actionBar.title)

activity.setTitle(R.string.connect_learn_title)

assertEquals(app.getString(R.string.connect_learn_title), actionBar.title)
assertNull(actionBar.subtitle)
}

private fun launchHome(): ConnectDeliveryHomeFragment {
val intent =
Intent(app, ConnectActivity::class.java).apply {
Expand Down
Loading