QA-8695 Update Connect Toolbar Title When Leaving Delivery Screens

[OrangeAndGreen]

QA-8695

Product Description

After visiting a delivery opportunity, the Connect toolbar kept that opportunity's name and "Delivery progress" subtitle on the opportunity list and on learn/intro screens. Each screen now shows its own title.

Technical Summary

ConnectActivity sets the action bar title directly in onPostCreate, and AppCompat ignores Activity.setTitle once that has happened, so the four Connect screens using requireActivity().setTitle(...) never updated the toolbar. ConnectActivity now routes setTitle to setActionBarTitle, which also clears the subtitle.

Safety Assurance

Safety story

What gives confidence:

• One override in ConnectActivity; the existing setTitle callers are unchanged and now take effect.
• The new test fails without the fix and passes with it; the rest of ConnectDeliveryHomeFragmentTest passes.

Automated test coverage

ConnectDeliveryHomeFragmentTest checks that after the delivery home sets its title and subtitle, a later setTitle replaces the title and clears the subtitle.

🤖 Generated with Claude Code

[OrangeAndGreen]

Suggested Review Order

• app/src/org/commcare/activities/connect/ConnectActivity.java — the setTitle override is the whole fix
• app/unit-tests/src/org/commcare/fragments/connect/ConnectDeliveryHomeFragmentTest.kt — reproduces the stale delivery title and subtitle

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a0f02ff2-44a9-48f0-8dc6-917c2e98619d

---

📥 Commits

Reviewing files that changed from the base of the PR and between 861d0bb and 0dd2f56.

---

📒 Files selected for processing (2)

• app/src/org/commcare/activities/connect/ConnectActivity.java
• app/unit-tests/src/org/commcare/fragments/connect/ConnectDeliveryHomeFragmentTest.kt

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Walkthrough

Walkthrough

ConnectActivity now updates the action bar title when setTitle is called. A test checks that a later screen title replaces the delivery title and that the action bar subtitle is null.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: shubham1g5

---

Merge Risk: ⚪ Minimal · up to 0dd2f

No material merge-blocking risk is established for this title update.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly identifies the ticket and the primary change: updating the Connect toolbar title when leaving delivery screens.
Description check		The description includes the product impact, technical rationale, safety story, automated test coverage, and ticket links. It does not include the required Labels and Review checklist, so risk-label a…

---

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.39%. Comparing base (f4b6c1b) to head (0dd2f56).
⚠️ Report is 7 commits behind head on commcare_2.65.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             commcare_2.65    #3963      +/-   ##
===================================================
+ Coverage            37.32%   37.39%   +0.07%     
- Complexity            6864     6871       +7     
===================================================
  Files                 1034     1034              
  Lines                61094    61098       +4     
  Branches              7472     7472              
===================================================
+ Hits                 22802    22848      +46     
+ Misses               35637    35586      -51     
- Partials              2655     2664       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.