Repository navigation
add resource filter parameters to sizes list #1281
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| cpu_minimum: | ||
| in: query | ||
| name: cpu_minimum | ||
| description: Filter sizes with an inclusive minimum CPU count | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| minimum: 1 | ||
| example: 4 | ||
|
|
||
| cpu_maximum: | ||
| in: query | ||
| name: cpu_maximum | ||
| description: Filter sizes with an inclusive maximum CPU count | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| minimum: 1 | ||
| example: 4 | ||
|
|
||
| gpu_minimum: | ||
| in: query | ||
| name: gpu_minimum | ||
| description: Filter sizes with an inclusive minimum GPU count | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| minimum: 1 | ||
| example: 1 | ||
|
|
||
| gpu_maximum: | ||
| in: query | ||
| name: gpu_maximum | ||
| description: Filter sizes with an inclusive maximum GPU count. Zero is allowed to filter to sizes without GPUs. | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| minimum: 0 | ||
| example: 8 | ||
|
|
||
| gpu_fabric: | ||
| in: query | ||
| name: gpu_fabric | ||
| description: Filter sizes to those with a given GPU fabric setting | ||
| required: false | ||
| schema: | ||
| type: boolean | ||
| example: true | ||
|
|
||
| memory_minimum: | ||
| in: query | ||
| name: memory_minimum | ||
| description: Filter sizes with an inclusive minimum memory amount (in megabytes) | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| multipleOf: 8 | ||
| minimum: 8 | ||
| example: 1024 | ||
|
|
||
| memory_maximum: | ||
| in: query | ||
| name: memory_maximum | ||
| description: Filter sizes with an inclusive maximum memory amount (in megabytes) | ||
| required: false | ||
| schema: | ||
| type: integer | ||
| multipleOf: 8 | ||
| minimum: 8 | ||
| example: 1024 | ||
|
|
||
| price_hourly_minimum: | ||
| in: query | ||
| name: price_hourly_minimum | ||
| description: Filter sizes with an inclusive minimum hourly price (in USD) | ||
| required: false | ||
| schema: | ||
| type: string | ||
|
Contributor
There was a problem hiding this comment. Size prices are number/float, should these filters match that, or stay string with a pattern if the API expects decimals?
Contributor
Author
There was a problem hiding this comment. string should be ok here. we're transitioning our price outputs to string as well. ideally all currencies would be presented as strings. |
||
| example: "0.50" | ||
|
|
||
| price_hourly_maximum: | ||
| in: query | ||
| name: price_hourly_maximum | ||
| description: Filter sizes with an inclusive maximum hourly price (in USD) | ||
| required: false | ||
| schema: | ||
| type: string | ||
| example: "1.00" | ||
|
|
||
| price_monthly_minimum: | ||
| in: query | ||
| name: price_monthly_minimum | ||
| description: Filter sizes with an inclusive minimum monthly price (in USD) | ||
| required: false | ||
| schema: | ||
| type: string | ||
| example: "5.00" | ||
|
|
||
| price_monthly_maximum: | ||
| in: query | ||
| name: price_monthly_maximum | ||
| description: Filter sizes with an inclusive maximum monthly price (in USD) | ||
| required: false | ||
| schema: | ||
| type: string | ||
| example: "10.00" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gpu_fabricis not on the size/gpu_info response, should we document it there or clarify what true/false means here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabric is a property of some 8x GPU sizes. it's to do with the networking between GPUs. customers who use this feature are very aware of it.
currently this information is baked into the slug name, which is a bit suboptimal. We could also supplement the gpu object to have a fabric boolean. I'll make a note here to bring this idea up with the team at standup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a fabric boolean has been added to the GPU info object