Skip to content

add resource filter parameters to sizes list - #1281

Open
a-talsma wants to merge 2 commits into
digitalocean:mainfrom
a-talsma:v2-sizes-resource-filters
Open

a-talsma wants to merge 2 commits into
digitalocean:mainfrom
a-talsma:v2-sizes-resource-filters

Conversation

@a-talsma

Copy link
Copy Markdown
Contributor

This PR documents resource filter parameters now available on GET /v2/sizes

description: Filter sizes to those with a given GPU fabric setting
required: false
schema:
type: boolean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpu_fabric is not on the size/gpu_info response, should we document it there or clarify what true/false means here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabric is a property of some 8x GPU sizes. it's to do with the networking between GPUs. customers who use this feature are very aware of it.

currently this information is baked into the slug name, which is a bit suboptimal. We could also supplement the gpu object to have a fabric boolean. I'll make a note here to bring this idea up with the team at standup.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a fabric boolean has been added to the GPU info object

description: Filter sizes with an inclusive minimum hourly price (in USD)
required: false
schema:
type: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size prices are number/float, should these filters match that, or stay string with a pattern if the API expects decimals?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string should be ok here. we're transitioning our price outputs to string as well.

ideally all currencies would be presented as strings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants