Skip to content

COBS-1696: Align Insights tracing wire contract - #1179

Merged
kishlay-singh-DO merged 3 commits into
digitalocean:mainfrom
dmamidala-glitch:cobs-1696-tracing-contract
Oct 21, 2026
Merged

kishlay-singh-DO merged 3 commits into
digitalocean:mainfrom
dmamidala-glitch:cobs-1696-tracing-contract

Conversation

@dmamidala-glitch

Copy link
Copy Markdown
Contributor

Summary

Aligns the Insights spans and traces clients with the snake_case, logs-style FilterExpression contract deployed by internal cthulhu#180856 for COBS-1704 and COBS-1725.

  • sends time_range / order_by and decodes snake_case tracing response and pagination fields
  • models filters as condition / and / or / not / text_search nodes with logs-style typed values and deployed enum values
  • retains the flat filter/value fields introduced by #1156 and #1162 as deprecated source-compatible inputs, translating them at marshal/unmarshal boundaries and rejecting mixed representations
  • updates raw wire tests, snake_case fixtures, and the Insights smoke example

Until this change is included in a godo release, doctl will pin this commit via a Go pseudo-version.

Testing

  • go test ./...
  • go test -race ./...
  • go vet ./...
  • focused Insights tracing contract tests

dmamidala-glitch and others added 3 commits October 21, 2026 15:19
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@dmamidala-glitch
dmamidala-glitch marked this pull request as ready for review October 21, 2026 10:48
@kishlay-singh-DO
kishlay-singh-DO merged commit efbddc6 into digitalocean:main Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants