Repository navigation
COBS-1696: Align Insights tracing wire contract - #2063
Merged
kishlay-singh-DO merged 3 commits intoOct 21, 2026
Merged
kishlay-singh-DO merged 3 commits into
kishlay-singh-DO merged 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
dmamidala-glitch
marked this pull request as ready for review
October 21, 2026 12:59
Co-authored-by: Cursor <cursoragent@cursor.com>
kishlay-singh-DO
approved these changes
Oct 21, 2026
SSharma-10
pushed a commit
that referenced
this pull request
Oct 22, 2026
* Add Insights command foundation (#2038) Co-authored-by: Cursor <cursoragent@cursor.com> * Add Insights notification channel and alert rule commands (#2043) * Add Insights alert instance, PromQL, and logs commands (#2044) * Add Insights alert instance, PromQL, and logs commands Add doctl insights alert-instance (list, get), metrics (query, query-range, labels, label-values, series), and logs search commands backed by the Insights service, with input validation, text and Prometheus-shaped JSON output, and unit tests. Related: COBS-1695 * Fix Insights flag help placeholders pflag treats the first backticked word in a flag's usage as its value placeholder, which produced help such as --end 2026-09-01T00:00:00Z. Drop incidental backticks and keep only intentional placeholders. * Reuse shared Insights helpers from alert rule commands Use the shared Insights flag names, AddStringArrayFlag and getInsightsStringArray for --match, readInsightsRequest for logs request and filter files (adding YAML support), and rejectRequestFileFlagMix for request-file conflicts. * Add Insights spans and traces commands (#2047) Co-authored-by: Cursor <cursoragent@cursor.com> * Add Insights resource enablement commands (#2061) Co-authored-by: Cursor <cursoragent@cursor.com> * COBS-1696: Align Insights tracing wire contract (#2063) * Align Insights tracing wire contract Co-authored-by: Cursor <cursoragent@cursor.com> * Correct Insights tracing filter help Co-authored-by: Cursor <cursoragent@cursor.com> * Update godo to v1.230.0 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * Fix Insights logs validation test spelling Co-authored-by: Cursor <cursoragent@cursor.com> * Confirm destructive Insights deletes Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: srajputdo <sakshirajput@digitalocean.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the doctl Insights spans and traces commands with the snake_case, logs-style filter contract now deployed in S2R1.
Depends on:
The current godo dependency is a pseudo-version at the merged commit. Replace it with the next tagged godo release before this PR is merged.
Validation
go build -mod=vendor -o /tmp/doctl-cobs-1696 ./cmd/doctlgo test -mod=vendor ./commands ./commands/displayers -run Insights -count=1go test -race -mod=vendor ./commands ./commands/displayers -run Insights -count=1go vet -mod=vendor ./...go test -mod=vendor ./... -skip ^TestRegistryLogout$The unmodified full suite only fails at the unrelated macOS keychain-dependent
TestRegistryLogout(credentials not found in native keychain).S2R1 follow-up
Resource update for a nonexistent resource still returns backend HTTP 500 rather than 404; this is independent of the doctl tracing change.