feat: unapplied changes status indicator and update button removal from modals [DHIS2-22011] - #365
Draft
HendrikThePendric wants to merge 18 commits into
Draft
HendrikThePendric wants to merge 18 commits into
HendrikThePendric wants to merge 18 commits into
Conversation
Contributor
|
🚀 Deployed on https://pr-365.event-visualizer.netlify.dhis2.org |
HendrikThePendric
force-pushed
the
feat/unapplied-changes-DHIS2-22011
branch
from
September 2, 2026 10:17
235e427 to
4693c1e
Compare
HendrikThePendric
force-pushed
the
feat/unapplied-changes-DHIS2-22011
branch
from
September 2, 2026 12:00
4693c1e to
87f019f
Compare
…mparison [DHIS2-22011]
metadata, populatedVis, and the STAGE_ID/DIMENSION_ID constants were duplicated verbatim across unapplied-changes-notice.spec.tsx and use-has-unapplied-changes.spec.ts, including the digitGroupSeparator explanatory comment. Extract them into a shared fixture module, following the existing __fixtures__ convention used elsewhere in src/components.
…2011] The submit handler received the event and ignored it, so closing relied on Chromium aborting the navigation because React had already unmounted the disconnected form — and it logged a console warning on every dismiss. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…n [DHIS2-22011] The comparison ran an API-shaped visualization against a builder-shaped one for the first time, and the API returns more than the builder can rebuild: option sets and legend sets carry their name, a repetition carries the context the backend derives, and the custom value carries its name and aggregation type. Each difference read as an unapplied change. Nested metadata refs now compare by id. The wire-only dy/latitude/longitude dimensions are dropped when normalizing instead of downstream, which also flips the legacy flag since it changes the persisted shape. Load-path tests cover each case; every one of them fails without the fix.
…ttom bar [DHIS2-22011] A pill floating over the canvas sat below the line list's fetch overlay and was not reliably visible. The bottom bar holds the buttons that apply the change, so the note belongs beside them, styled like the title bar's Edited suffix. It now shows only when a change can actually be applied: no applicable output type means nothing to hint at, and a selected output type that is no longer applicable means the config changed since it was applied. Output type validity moves out of useActionButton into a pure module so the buttons and the note share one source of truth, and gains the check it was missing -- a tracked entity output with no tracked entity type in the layout now disables the button, which was previously enabled and threw on click.
…iant [DHIS2-22011]
The section described sibling DHIS2 apps' helpers, none of which exist in this repo, so it pointed readers at symbols they could not find.
HendrikThePendric
force-pushed
the
feat/unapplied-changes-DHIS2-22011
branch
from
September 3, 2026 06:59
76ac58b to
3822ec4
Compare
4 tasks
edoardo
reviewed
Sep 3, 2026
|
|
||
| export type TooltipConfig = { content: string; openDelay?: number } | undefined | ||
|
|
||
| const getRegistrationOuTooltipContent = (): TooltipConfig => ({ |
Member
There was a problem hiding this comment.
In my PR I renamed these functions to get[something]TooltipConfig since the returned value is a tooltip config object, not just the content.
Collaborator
Author
There was a problem hiding this comment.
Odd.... I don't get any conflicts? Maybe you refer to an open PR?
…pplied-changes-DHIS2-22011 # Conflicts: # i18n/en.pot # src/components/options/options-modal.tsx
|
HendrikThePendric
marked this pull request as draft
September 10, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-22011
Description
This PR consists of two main points:
This new UX brings much more clarity at the cost of an extra click.
Quality checklist
Known issues