refactor: reorganise visualization module - #367
Draft
HendrikThePendric wants to merge 1 commit into
Draft
HendrikThePendric wants to merge 1 commit into
HendrikThePendric wants to merge 1 commit into
Conversation
Some files had grown a bit out of control
Contributor
|
🚀 Deployed on https://pr-367.event-visualizer.netlify.dhis2.org |
|
edoardo
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements N/A
Description
This does not need a thorough review since all this PR does is move some stuff around.
The main issue was that
state.tsheld six unrelated concerns in 684 lines. Each now lives in a file with a more specific name. I tried to stick to the general guideline that says "a file should be named for what it produces", but this didn't always work completely, so we now ended up withguards,normalize-legacy,ui-config,save, andcurrent-vis(which now also hasbuildCurrentVisFromVisUiConfigfrom the store, since that produces aCurrentVisualization).state.tskeeps the comparison.removeDimensionPropertiesBeforeSavingwas moved to the dimension domain: it produces aDimensionArrayand has callers in two concerns.Quality checklist
ToDo