Repository navigation
ci(desktop): make lint-and-test an always-reporting gate job - #665
Merged
Merged
Conversation
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
skevetter
force-pushed
the
ci/require-desktop-lint-and-test
branch
3 times, most recently
from
July 14, 2026 16:07
a6ded54 to
5d0961c
Compare
Split path filtering out of the workflow trigger and into a 'changes' job so Desktop CI runs on every PR. lint-and-test now always reports a status, skipping its steps when desktop/** is untouched, so it can be added to the branch ruleset as a required check without blocking non-desktop PRs. build-desktop and build-flatpak stay gated on the desktop filter.
skevetter
force-pushed
the
ci/require-desktop-lint-and-test
branch
from
July 14, 2026 16:25
5d0961c to
cc1c235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures Desktop CI so
lint-and-testcan be added to the branch ruleset as a required status check without blocking PRs that don't touch the desktop app.Previously the workflow used a
paths:trigger filter, solint-and-testonly ran ondesktop/**changes. A required status check that never runs blocks a PR indefinitely ("waiting for status"), so the check couldn't safely be made required as-is.Changes
changesjob (dorny/paths-filter), mirroring the existing pattern inpr-ci.yml.lint-and-testnow runs on every PR and reports a status. Its steps are conditioned onneeds.changes.outputs.desktop == 'true', so it succeeds instantly when the desktop app is untouched and runs the real type-check + unit tests when it isn't.build-desktopandbuild-flatpakremain gated behind the desktop filter.Follow-up
Once this merges,
lint-and-testwill be added to thedefaultrepository ruleset's required status checks.