Repository navigation
fix(desktop): resolve unsatisfiable vite/typescript peer deps - #666
Conversation
main's desktop dependency tree could not be installed (npm ci failed with ERESOLVE), which had gone unnoticed because Desktop CI was not a required check. Two independent breaks: - @sveltejs/vite-plugin-svelte@7.2.0 requires vite ^8, but electron-vite@5 only supports vite <=7, so no vite version satisfied both. Pin vite to 7.3.6 and downgrade vite-plugin-svelte to 6.2.4 (peer vite ^6.3||^7). - typescript@7.0.2 (native port) crashes svelte-check@4.7.2, which has no TS 7 support yet. Pin typescript to 6.0.3. npm ci, svelte-check, and vitest all pass locally.
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
❌ Deploy Preview for images-devsy-sh failed.
|
…en majors Prevent Renovate from re-bumping the packages this PR downgraded back into an uninstallable state: - vite <8: electron-vite 5 rejects vite 8 - @sveltejs/vite-plugin-svelte <7: v7 requires vite 8 - typescript <7: svelte-check 4 crashes on TS 7 Scoped to desktop/** so other workspaces are unaffected. Remove these caps once electron-vite ships stable vite 8 support and svelte-check supports TS 7.
|
Added a commit pinning |
1 participant
Summary
main's desktop dependency tree cannot be installed —npm cifails withERESOLVE. This went unnoticed because Desktop CI (lint-and-test) is not a required status check, so broken dependency updates merged.Two independent breaks, both surfaced once
npm ciwas made to work:@sveltejs/vite-plugin-svelte@7.2.0requiresvite ^8, butelectron-vite@5.0.0only acceptsvite ^5 || ^6 || ^7. No vite version satisfies both. Fixed by pinningvite@7.3.6and downgrading@sveltejs/vite-plugin-svelte@6.2.4(peervite ^6.3 || ^7).typescript@7.0.2(the native port, bumped in chore(deps): update dependency typescript to v7 #663) crashessvelte-check@4.7.2, which has no TS 7 support yet (npm run checkthrowsCannot read properties of undefined (reading 'useCaseSensitiveFileNames')). Fixed by pinningtypescript@6.0.3.Verification
All three Desktop CI steps pass locally against the regenerated lockfile:
npm ci— clean installnpm run check— 0 errorsnpm run test— 249 passedRelated
electron-viteships stable vite-8 support; only6.0.0-beta.1has it).lint-and-testreport on every PR so it can become a required check.