Skip to content

fix(desktop): keep workspace status pill at intrinsic width #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 2 commits into from
Sep 21, 2026
+8 −1
Merged

fix(desktop): keep workspace status pill at intrinsic width #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d7a139
fix(desktop): keep workspace status pill at intrinsic width
skevetter Sep 21, 2026
e67b757
test(desktop): cover status pill intrinsic width
skevetter Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ async function retryRefresh(event: MouseEvent) {
}
}
</script>
<div aria-live="polite" aria-busy={workspaceJobBusy(job)} class="flex flex-col gap-1">
<div aria-live="polite" aria-busy={workspaceJobBusy(job)} class="flex flex-col items-start gap-1">
<span class={badgeVariants({ variant: job?.error ? "destructive" : label ? "secondary" : status?.toLowerCase() === "running" ? "default" : "outline" })}>
{#if workspaceJobBusy(job)}<Spinner class="size-3" />{/if}
{label ?? status ?? "Checking"}
Expand Down
7 changes: 7 additions & 0 deletions desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ beforeEach(() => {
vi.clearAllMocks()
})
describe("WorkspaceOperation", () => {
it("keeps the status pill at intrinsic width inside the live region", () => {
const ui = render(WorkspaceOperation, { id: "ws", status: "Running" })
const badge = ui.getByText("Running")
const liveRegion = badge.parentElement
expect(liveRegion?.classList.contains("flex-col")).toBe(true)
expect(liveRegion?.classList.contains("items-start")).toBe(true)
})
it("keeps the action visible over a stale runtime observation", () => {
workspaceJobs.set({
ws: {
Expand Down
Loading