Skip to content

fix(desktop): keep workspace status pill at intrinsic width - #1252

Merged
skevetter merged 2 commits into
mainfrom
fix/desktop-status-pill-width
Sep 21, 2026
Merged

skevetter merged 2 commits into
mainfrom
fix/desktop-status-pill-width

Conversation

@skevetter

@skevetter skevetter commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Problem

On the Workspaces page the Status badge ("Running", "Stopped", live operation labels) stretched across the full Status column instead of rendering as a compact pill.

Cause

WorkspaceOperation wraps the badge in a flex flex-col live region. Column flex containers default to align-items: stretch, so the badge - as a flex item - stretched to the container width, which fills the table cell.

Fix

Add items-start to the live region so the badge and the phase/error lines size to their content. One-class change; all four usages (workspaces table, workspace card, workspace detail header, create wizard progress) keep their layout.

Tests

  • New unit test pins the intrinsic-width contract on the live region.
  • svelte-check clean; full renderer suite green (45 files, 417 tests); full Playwright e2e suite green (55 tests) under Xvfb.
  • Rendered the actual Electron app against the mock backend and inspected the Workspaces page at 1200px and 700px, idle and during a live create: pills are compact, spinner and phase text stay readable.

Summary by CodeRabbit

  • Bug Fixes

    • Improved the workspace operation status display so status pills align correctly and fit their content width.
  • Tests

    • Added coverage verifying the layout of the “Running” status indicator.

Signed-off-by: Samuel K <skevetter@pm.me>
Signed-off-by: Samuel K <skevetter@pm.me>
@netlify

netlify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit e67b757
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ab0b2c721fe8300080c4f2c

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0fc4b91c-a766-461e-98a5-ee5bc39bb4a1

📥 Commits

Reviewing files that changed from the base of the PR and between b88fad1 and e67b757.

📒 Files selected for processing (2)
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.svelte
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workspace operation status container now aligns children to the cross-axis start. A test verifies the flex-col and items-start classes for the running status live region.

Changes

Workspace operation layout

Layer / File(s) Summary
Status container alignment and validation
desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.svelte, desktop/src/renderer/src/lib/components/workspace/WorkspaceOperation.test.ts
The status container adds items-start to its flex-column classes. The test verifies the flex-col and items-start classes for the running status live region.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: preventing the workspace status pill from stretching beyond its intrinsic width.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit e67b757
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ab0b2c7ca653b00081754dd

@skevetter
skevetter marked this pull request as ready for review September 21, 2026 04:55
@mergify

mergify Bot commented Sep 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@skevetter
skevetter merged commit 78fe51d into main Sep 21, 2026
31 checks passed
@skevetter
skevetter deleted the fix/desktop-status-pill-width branch September 21, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant