feat(pptx): add opt-in hidden slide inclusion - #1758
Merged
developer0hye merged 1 commit intoSep 17, 2026
Merged
Conversation
Signed-off-by: Anand C. Patel <acpatel@flagshippioneering.com>
developer0hye
marked this pull request as ready for review
September 17, 2026 10:47
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Summary
Add an opt-in path for exporting hidden PPTX slides while preserving the existing default that omits them.
ConvertOptions.include_hidden_slides, defaulting tofalse.--include-hidden-slidesand pass it through to the PPTX parser.show="0"andshow="false"slides in original presentation order when enabled.--slidesranges based on original one-based source positions.Related issue
Related: #1755
Testing
These are focused local checks; the full workspace suite was not run locally.
cargo test --locked -p office2pdf config::tests::test_convert_optionscargo test --locked -p office2pdf parser::pptx::tests::slide_feature_tests::test_cargo test --locked -p office2pdf-cli test_cli_include_hidden_slidescargo test --locked -p office2pdf --features typescript config::ts_testscargo test --locked -p office2pdf --features typescript ts_integration_testscargo test --locked -p office2pdf-cli --features server test_parse_query_stringcargo run --locked -p office2pdf-cli -- --helpcargo fmt --all -- --checkgit diff --checkVisual impact
Checklist
Signed-off-byline