fix(pptx): correct hidden-slide comment for include_hidden_slides - #1780
Merged
Merged
Conversation
#1758 added the include_hidden_slides opt-in but left the call-site comment describing unconditional omission. Update it to match parse_single_slide's own docstring, name both show="0"/show="false" encodings, and restore a blank line the PR's diff had dropped. Related: #1758 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File submission policy
Summary
#1758 added the
include_hidden_slidesopt-in but left a call-site commentin
PptxParser::parsedescribing unconditional hidden-slide omission. Thisnow contradicts
parse_single_slide's own updated docstring. Update thecomment to match, name both
show="0"andshow="false"encodings, andrestore a blank line the PR's diff had dropped for no reason.
Comment-only change; no behavior change.
Related issue
Related: #1758
Testing
cargo fmt --all -- --checkcargo build --locked -p office2pdfcargo test --locked -p office2pdf pptxVisual impact
crates/office2pdf/src/parser/pptx.rs; no drawing or layout code changed.Checklist
Signed-off-byline