Skip to content

fix(pptx): correct hidden-slide comment for include_hidden_slides - #1780

Merged
developer0hye merged 1 commit into
mainfrom
fix/hidden-slide-comment
Sep 17, 2026
Merged

developer0hye merged 1 commit into
mainfrom
fix/hidden-slide-comment

Conversation

@developer0hye

Copy link
Copy Markdown
Owner

File submission policy

  • No sample documents, attachments, or private fixtures are submitted.

Summary

#1758 added the include_hidden_slides opt-in but left a call-site comment
in PptxParser::parse describing unconditional hidden-slide omission. This
now contradicts parse_single_slide's own updated docstring. Update the
comment to match, name both show="0" and show="false" encodings, and
restore a blank line the PR's diff had dropped for no reason.

Comment-only change; no behavior change.

Related issue

Related: #1758

Testing

  • cargo fmt --all -- --check
  • cargo build --locked -p office2pdf
  • cargo test --locked -p office2pdf pptx

Visual impact

  • No rendered PDF change
  • Rendered PDF change or visual evidence added
  • Reason: Comment-only change in crates/office2pdf/src/parser/pptx.rs; no drawing or layout code changed.

Checklist

  • Commits include a Signed-off-by line
  • PR scope contains one root cause
  • Remaining converter or harness deviations each reference an open issue (none introduced)

#1758 added the include_hidden_slides opt-in but left the call-site
comment describing unconditional omission. Update it to match
parse_single_slide's own docstring, name both show="0"/show="false"
encodings, and restore a blank line the PR's diff had dropped.

Related: #1758

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
@developer0hye
developer0hye merged commit cbcf669 into main Sep 17, 2026
18 checks passed
@developer0hye
developer0hye deleted the fix/hidden-slide-comment branch September 17, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant